Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more information about blocks and blocks error handling. #54429

Merged
merged 4 commits into from
Apr 5, 2019
Merged

Adding more information about blocks and blocks error handling. #54429

merged 4 commits into from
Apr 5, 2019

Conversation

caiohsramos
Copy link
Contributor

Signed-off-by: Caio Ramos caioramos97@gmail.com
Signed-off-by: Gabriely Pereira gabriely.pereira@usp.br

SUMMARY

Adding more information about Blocks error handling in the Error handling page. Also, adding ignore_errors in the example at the Blocks documentation.

Fixes #27165

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docsite
playbooks_blocks.rst
playbooks_error_handling.rst

ADDITIONAL INFORMATION

https://docs.ansible.com/ansible/devel/user_guide/playbooks_blocks.html
https://docs.ansible.com/ansible/devel/user_guide/playbooks_error_handling.html

@caiohsramos
Adding more information about blocks and blocks error handling.
a12c4de 
Signed-off-by: Caio Ramos <caioramos97@gmail.com>
Signed-off-by: Gabriely Pereira <gabriely.pereira@usp.br>
@ansibot
Copy link
Contributor

ansibot commented Mar 26, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 26, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 28, 2019
@jamescassell @caiohsramos
Update docs/docsite/rst/user_guide/playbooks_error_handling.rst
4c36138 
Removing undefined variables as not rescuable errors.

Co-Authored-By: caiohsramos <caioramos97@gmail.com>
@caiohsramos
Copy link
Contributor Author

ready_for_review

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 28, 2019
jamescassell
jamescassell approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@caiohsramos
Update playbooks_blocks.rst
1b7423d 
Removing undefined variables as not rescuable errors.
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 28, 2019
@caiohsramos caiohsramos reopened this Mar 28, 2019
@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 28, 2019
@felixfontein @caiohsramos
Apply suggestions from code review
dc1aa4f 
Co-Authored-By: caiohsramos <caioramos97@gmail.com>
felixfontein
felixfontein approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. labels Apr 3, 2019
@acozine acozine merged commit 1de1d08 into ansible:devel Apr 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamescassell jamescassell jamescassell approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There are two doc pages about error handlers which don't refer to each other
5 participants
@caiohsramos @ansibot @jamescassell @felixfontein @acozine