AWS: add ec2_transit_gateway_info module #54460
Conversation
|
needs_ci_update |
ansibot
added
affects_2.8
|
@mattclay As this is a basic info module, should I wait on perms, or change aliases to unsupported? |
|
@BobBoldin I've updated CI permissions so this test will now pass. I'm also going to enable the existing To improve test performance and avoid unnecessarily creating and deleting transit gateways, please add the integration tests for this module to the existing |
mattclay
removed
the
needs_triage
|
@BobBoldin I also had to mark the |
mattclay
added
the
ci_verified
|
@mattclay to confirm, Reviewed Confirmed in https://app.shippable.com/github/ansible/ansible/runs/116823/105/console is the same tgw-03192e0bac40a297f Is there way to make those 2 steps run serial? Otherwise I'll look to describe them dynamically so one doesn't detect the other. |
|
@BobBoldin Correct, remove the Tests run in parallel because they run on multiple Python versions. Tests from other PRs may also run in parallel. Also, transit gateways that are deleted will remain in the account for some time in the deleted state even after the test finishes. The tests will need to handle these situations gracefully to prevent intermittent test failures. |
BobBoldin
force-pushed
the
ec2_transit_gateway_info
branch
from
1c19364
to
8a22155
Compare
ansibot
removed
the
ci_verified
|
@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Madhura-CSI @MichaelBaydoun @Sodki @Zeekin @adq @akazakov @alachaum @amir343 @anryko @bekelchik @brandond @captainkerk @chenl87 @defunctio @dennisconrad @dkhenry @fiunchinho @fivethreeo @flowerysong @garethr @gobins @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @michaeljs1990 @minichate @mjschultz @mmochan @nand0p @naslanidis @nathanwebsterdotme @nerzhul @nickball @orthanc @ozbillwang @piontas @pjodouin @prasadkatti @psykotox @ptux @pwnall @raags @rafaeldriutti @rickmendes @roadmapper @rrey @ryansb @ryansydnor @scicoin-project @scottanderson42 @sdubrul @shepdelacreme @silviud @slapula @steynovich @tastychutney @tgerla @timmahoney @tombamford @tomislacker @tsiganenok @viper233 @whiter @willricardo @wilvk @wimnat @yaakov-github @zacblazic @zbal @zimbatm As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add |
ansibot
added
community_review
|
ready_for_review |
| @@ -1,3 +1,4 @@ | |||
| cloud/aws | |||
| shippable/aws/group2 | |||
| unstable # sometimes tries to delete while in state pending | |||
| ec2_transit_gateway_info | |||
There was a problem hiding this comment.
Interesting, I didn't knew this can be done. I guess I have to look into that :)
There was a problem hiding this comment.
CI team suggested as it increases efficiency in tests. Otherwise was having to create new resources simply to get results for the _info
There was a problem hiding this comment.
I've the same situation for other modules, that would improve global test performance somewhat.
ansibot
added
shipit
ansibot
added
community_review
…ntification in testing
|
All tests pass for me |
|
Merged, thanks @BobBoldin |
* AWS: add ec2_transit_gateway_info module * move info module test to main module and ensure unique description for parallel tests * add type designators to module options in documentation * assign results and return instead of exit. Add elements directive available with ansible 2.8 * assign results and return instead of exit * get() method superfluous for module.params * correct return type in documentation for ASN and format the sample for Tag correctly * added random uid to test description - removing unstable alias * change random uuid to resource_prefix to improve source of object identification in testing
SUMMARY
Add new info module ec2_transit_gateway_info to compliment the ec2_transit_gateway module
ISSUE TYPE
COMPONENT NAME
ec2_transit_gateway_info
ADDITIONAL INFORMATION
Module will return information about AWS Transit Gateway objects. Used _info in name to conform with issue #54280
To pass integration tests will need permissions from network-policy.json added to CI environment.
'''
{
"Sid": "AllowTransitGatewayManagement",
"Effect": "Allow",
"Action": [
"ec2:CreateTransitGateway",
"ec2:DeleteTransitGateway",
"ec2:DescribeTransitGateways"
],
"Resource": "*"
}
'''