Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipaddr: Update docs #54587

Merged
merged 1 commit into from
Apr 5, 2019
Merged

ipaddr: Update docs #54587

merged 1 commit into from
Apr 5, 2019

Conversation

Akasurde
Copy link
Member

SUMMARY

Added docs for

  • next_nth_usable
  • next_usable
  • range_usable
  • last_usable

Fixes: #50546

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/user_guide/playbooks_filters_ipaddr.rst

@Akasurde Akasurde mentioned this pull request Mar 29, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Mar 29, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 29, 2019
@IPvSean
Copy link
Contributor

IPvSean commented Apr 3, 2019

looks great!
great job

acozine
acozine reviewed Apr 3, 2019
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition to the filter documentation, thanks @Akasurde.

I've added some suggestions to make the examples easier to find and parse.

docs/docsite/rst/user_guide/playbooks_filters_ipaddr.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_filters_ipaddr.rst Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_filters_ipaddr.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_filters_ipaddr.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_filters_ipaddr.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_filters_ipaddr.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_filters_ipaddr.rst Outdated Show resolved Hide resolved
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 3, 2019
@Akasurde
ipaddr: Update docs
78cbe80 
Added docs for

* next_nth_usable
* next_usable
* range_usable
* last_usable

Fixes: ansible#50546

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@acozine acozine merged commit 098e0af into ansible:devel Apr 5, 2019
@Akasurde Akasurde deleted the i50546 branch April 6, 2019 04:32
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add more ipaddr netaddr examples into filter documentation
4 participants
@Akasurde @ansibot @IPvSean @acozine