Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all of yum version compare operators #54603

Merged
merged 2 commits into from
Apr 8, 2019
Merged

Allow all of yum version compare operators #54603

merged 2 commits into from
Apr 8, 2019

Conversation

rosowiecki
Copy link
Contributor

@rosowiecki rosowiecki commented Mar 29, 2019 •
edited

SUMMARY

Improved fix for #47689, which allows all version comparison operators (not only '==').

Fixes: #47744

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum

ADDITIONAL INFORMATION

In our playbooks we often use yum: name= 'package >= VERSION' and we'd like ansible-2.7 to support it. Instead of listing all possible operators like '<=' '>=' yum module allows spaces when other special sign (@<>=) appers.

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 29, 2019
mkrizek
mkrizek requested changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@mkrizek mkrizek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but changelog and tests are missing.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 29, 2019
@rosowiecki
Copy link
Contributor Author

LGTM but changelog and tests are missing.

Is test/units/modules/packaging/os/test_yum.py a good choice for tests of this code?

@mkrizek
Copy link
Contributor

mkrizek commented Mar 29, 2019

See https://github.com/ansible/ansible/pull/47744/files#diff-d057b4b95cb10fb15c4e193ac5746861R560

@ansibot
Copy link
Contributor

ansibot commented Apr 1, 2019

cc @Akasurde @berenddeschouwer @kustodian @maxamillion @verm666
click here for bot help

@ansibot ansibot added packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. and removed needs_triage Needs a first human triage before being processed. labels Apr 1, 2019
@mkrizek mkrizek merged commit 1532e31 into ansible:devel Apr 8, 2019
@mkrizek
Copy link
Contributor

mkrizek commented Apr 8, 2019

Thanks @rosowiecki!

mkrizek pushed a commit to mkrizek/ansible that referenced this pull request Apr 8, 2019
@rosowiecki @mkrizek
Allow all of yum version compare operators (ansible#54603)
22fc501 
* Allow all of yum version compare operators

* * yum: name="foo >= VERSION" integration test
* changelog fragment

(cherry picked from commit 1532e31)
@mkrizek mkrizek mentioned this pull request Apr 8, 2019
Merged
@mkrizek
Copy link
Contributor

mkrizek commented Apr 8, 2019

@rosowiecki FYI I created a PR for this change to be backported to 2.7. See above.

abadger pushed a commit that referenced this pull request Apr 8, 2019
@rosowiecki @abadger
Allow all of yum version compare operators (#54603)
910d21e 
* Allow all of yum version compare operators

* * yum: name="foo >= VERSION" integration test
* changelog fragment

(cherry picked from commit 1532e31)
@rosowiecki rosowiecki deleted the allow_all_yum_version_specs branch April 9, 2019 11:27
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

@maxamillion maxamillion Awaiting requested review from maxamillion

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rosowiecki @mkrizek @ansibot