Removing provider from facts, command and config #54623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
Qalthos
approved these changes
Apr 3, 2019
ansibot
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removing provider dependency from the modules. The modules covered are cnos_facts, cnos_command and cnos_config
ISSUE TYPE
COMPONENT NAME
modified: lib/ansible/modules/network/cnos/cnos_facts.py
modified: test/integration/targets/cnos_facts/tests/cli/default_facts.yaml
deleted: test/integration/targets/cnos_facts/vars/main.yml (deleted)
modified: lib/ansible/modules/network/cnos/cnos_command.py
modified: test/integration/targets/cnos_command/README.md
modified: test/integration/targets/cnos_command/tests/cli/bad_operator.yaml
modified: test/integration/targets/cnos_command/tests/cli/contains.yaml
modified: test/integration/targets/cnos_command/tests/cli/invalid.yaml
modified: test/integration/targets/cnos_command/tests/cli/output.yaml
modified: test/integration/targets/cnos_command/tests/cli/timeout.yaml
deleted: test/integration/targets/cnos_command/vars/main.yaml
modified: lib/ansible/modules/network/cnos/cnos_config.py
modified: test/integration/targets/cnos_config/README.md
modified: test/integration/targets/cnos_config/cnos_config_sample_hosts
modified: test/integration/targets/cnos_config/tests/cli/backup.yaml
modified: test/integration/targets/cnos_config/tests/cli/basic.yaml
modified: test/integration/targets/cnos_config/tests/cli/defaults.yaml
deleted: test/integration/targets/cnos_config/vars/main.yml
ANSIBLE VERSION
ansible 2.8.0.dev0 (devel e2b9c36) last updated 2018/10/12 13:58:41 (GMT +550)
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/ansible/sheru/ansible/lib/ansible
executable location = /home/ansible/sheru/ansible/bin/ansible
python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]
ADDITIONAL INFORMATION
Please merge it now. This has been tested against 10.9.1 version of CNOS