Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BusyBox support to group module #54689

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Add BusyBox support to group module #54689

merged 2 commits into from
Apr 2, 2019

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Apr 1, 2019

SUMMARY

Fixes #29808

Use addgroup and delgroup for modifying groups on BusyBox based distributions.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

/lib/ansible/modules/system/group.py

ADDITIONAL INFORMATION

Since there is no command for easily modifying groups, I modify /etc/groups directly when changing the GID of a group. Not sure if that is ok or not.

@samdoran samdoran mentioned this pull request Apr 1, 2019
Closed
@samdoran samdoran requested a review from bcoca April 1, 2019 18:10
@ansibot
Copy link
Contributor

ansibot commented Apr 1, 2019

cc @sfromm
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category labels Apr 1, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 2, 2019
@bcoca bcoca merged commit 579e725 into ansible:devel Apr 2, 2019
@samdoran samdoran deleted the issue/29808-alpine-group branch April 2, 2019 14:39
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support addgroup in group-module
3 participants
@samdoran @ansibot @bcoca