Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_disk: really add new content types #54720

Merged
merged 1 commit into from
Apr 5, 2019
Merged

ovirt_disk: really add new content types #54720

merged 1 commit into from
Apr 5, 2019

Conversation

tiraboschi
Copy link
Contributor

SUMMARY

really add new content types to ovirt_disk module
Fixes: #54719

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_disk

ADDITIONAL INFORMATION

#54328 simply add them to the documentation:

    content_type:
        description:
            - Specify if the disk is a data disk or ISO image or a one of a the Hosted Engine disk types
            - The Hosted Engine disk content types are available with Engine 4.3+ and Ansible 2.8
        choices: ['data', 'iso', 'hosted_engine', 'hosted_engine_sanlock', 'hosted_engine_metadata', 'hosted_engine_configuration']

@tiraboschi
Copy link
Contributor Author

@machacekondra @mwperina @tnisan can you please review?

@ansibot
Copy link
Contributor

ansibot commented Apr 2, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_disk.py:633:161: E501 line too long (166 > 160 characters)

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 2, 2019

cc @mnecas
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. ovirt oVirt and RHV community small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Apr 2, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 2, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 2, 2019
@machacekondra
Copy link
Contributor

shipit

mwperina
mwperina approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 5, 2019
@ansibot ansibot merged commit 087587e into ansible:devel Apr 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@machacekondra machacekondra machacekondra left review comments

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
4 participants
@tiraboschi @ansibot @machacekondra @mwperina