Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_user: fix doc formatting, added return value, aliases, misc code changes #54768

Merged
merged 6 commits into from
Apr 4, 2019
Merged

postgresql_user: fix doc formatting, added return value, aliases, misc code changes #54768

merged 6 commits into from
Apr 4, 2019

Conversation

Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented Apr 3, 2019 •
edited

SUMMARY
  1. fixed doc formatting (added type, -name: instead of using comments in examples, etc)
  2. added return value
  3. misc code changes
  4. added aliases
  5. removed line from ignore.txt
ISSUE TYPE
  • Docs Pull Request

@ansibot
Copy link
Contributor

ansibot commented Apr 3, 2019

cc @Dorn- @amenonsen @andytom @jbscalia @kostiantyn-nemchenko @kustodian @matburt @nerzhul @sebasmannem
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. database Database category docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. labels Apr 3, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 3, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. labels Apr 3, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 3, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

cc @dschep @jensdepuydt
click here for bot help

@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 4, 2019
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Apr 4, 2019
gundalow
gundalow approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@gundalow gundalow merged commit 3eff72e into ansible:devel Apr 4, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. database Database category docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Andersson007 @ansibot @gundalow