Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in huaweicloud utils #54770

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Fix typo in huaweicloud utils #54770

merged 1 commit into from
Apr 3, 2019

Conversation

zhongjun2
Copy link
Contributor

@zhongjun2 zhongjun2 commented Apr 3, 2019

SUMMARY

minor typo fix

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/hwc_utils.py

ANSIBLE VERSION

ansible 2.8

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Apr 3, 2019
@TommyLike
Copy link

shipit

@zhongjun2
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Apr 3, 2019

Components

lib/ansible/module_utils/hwc_utils.py
support: community
maintainers:

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: TommyLike
automerge: automerge shipit test failed

click here for bot help

@gundalow gundalow closed this Apr 3, 2019
@gundalow gundalow reopened this Apr 3, 2019
@gundalow
Copy link
Contributor

gundalow commented Apr 3, 2019

BOTMETA tester says:

{
  "lib/ansible/module_utils/hwc_utils.py": {
    "assign": [
      "TommyLike",
      "edisonxiang",
      "freesky-edward",
      "niuzhenguo",
      "zengchen1024",
      "zhongjun2"
    ],
    "authors": [],
    "committers": [],
    "deprecated": false,
    "ignore": [],
    "labels": [
      "ansible",
      "cloud",
      "huawei",
      "hwc_utils",
      "lib",
      "module_utils"
    ],
    "maintainers": [
      "TommyLike",
      "edisonxiang",
      "freesky-edward",
      "niuzhenguo",
      "zengchen1024",
      "zhongjun2"
    ],
    "metadata": {},
    "name": "hwc_utils",
    "namespace": null,
    "namespace_maintainers": [],
    "notify": [
      "TommyLike",
      "edisonxiang",
      "freesky-edward",
      "niuzhenguo",
      "zengchen1024",
      "zhongjun2"
    ],
    "repo_filename": "lib/ansible/module_utils/hwc_utils.py",
    "subtopic": null,
    "supershipit": [],
    "support": "community",
    "supported_by": "community",
    "topic": null
  }
}

We can see owner_pr has been set, that's it

@gundalow
Copy link
Contributor

gundalow commented Apr 3, 2019

bot_status

@ansibot
Copy link
Contributor

ansibot commented Apr 3, 2019

Components

lib/ansible/module_utils/hwc_utils.py
support: community
maintainers:

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: TommyLike
automerge: automerge shipit test failed

click here for bot help

@gundalow gundalow merged commit eb77350 into ansible:devel Apr 3, 2019
@gundalow
Copy link
Contributor

gundalow commented Apr 3, 2019

Not sure why the bot isn't working correctly. Will investigate more later.

@zhongjun2 @TommyLike Thank you for the fix and review. Merged into devel

@bcoca bcoca removed feature This issue/PR relates to a feature request. labels Apr 3, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 9, 2019
@zhongjun2 zhongjun2 deleted the fix_typo branch April 16, 2019 08:30
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants