Don't swallow exceptions when processing included files

[sivel]

SUMMARY

Don't swallow exceptions when processing included files. Fixes #54786

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/plugins/strategy

ADDITIONAL INFORMATION

[bcoca]

not sure that this change is correct, AnsibleError is way too wide a trap, but we probably want to get 'failed to include' errors .. might be worth using specific exception class.

[sivel]

In the above case, it was swallowing AnsibleUndefinedVariable. However there have been other similar cases. I'm not sure I see any other exceptions being raised in that code that are ansible related. We'll catch AnsibleError higher up anyway, so I think it's safe to just let them fly.

[bcoca]

in one branch we are doing tqm run errors, which is a specific way of exiting, i would keep that behaviour for 'failing to include/import' .. other errors we still want to let through.

[sivel]

in one branch we are doing tqm run errors, which is a specific way of exiting

It ends up affecting the exit the same way. If we return with self._tqm.RUN_ERROR we get an exit code of 1. If we let the exception fly, we get an exception of 1. It shouldn't affect any current behaviors. But if you can think of a specific exception we should catch there, I'm game for limiting it.