Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for multiple LIFS instead of 1 at a time #54800

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Allow for multiple LIFS instead of 1 at a time #54800

merged 2 commits into from
Apr 10, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Allow for multiple LIFS instead of 1 at a time

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_cluster_peer.py
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 3, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 committer_review In order to be merged, this PR must follow the certified review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. storage support:certified This issue/PR relates to certified code. labels Apr 3, 2019
lonico
lonico approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed committer_review In order to be merged, this PR must follow the certified review workflow. needs_triage Needs a first human triage before being processed. labels Apr 3, 2019
thedoubl3j
thedoubl3j approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks like we are missing unit tests for this though. just wanted to get it on your radar

@carchi8py
Copy link
Contributor Author

@thedoubl3j good catch (i forgot to double check which unit test exist in 2.8 in our internal repo vs github, i'm missing quite a few). I'll upload this one now the other one now.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core labels Apr 10, 2019
lonico
lonico approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 10, 2019
thedoubl3j
thedoubl3j approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for getting those in @carchi8py, lgtm. shipit

@resmo resmo merged commit c51f840 into ansible:devel Apr 10, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carchi8py @ansibot @lonico @thedoubl3j @resmo