Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update na_ontap_export_policy_rule to allow multiple rules to be set at once. #54801

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Update na_ontap_export_policy_rule to allow multiple rules to be set at once. #54801

merged 2 commits into from
Apr 11, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Update na_ontap_export_policy_rule to allow multiple rules to be set at once.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_export_policy_rule.py
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 3, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 committer_review In order to be merged, this PR must follow the certified review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. storage support:certified This issue/PR relates to certified code. labels Apr 3, 2019
lonico
lonico approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed committer_review In order to be merged, this PR must follow the certified review workflow. needs_triage Needs a first human triage before being processed. labels Apr 3, 2019
lonico
lonico approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed owner_pr This PR is made by the module's maintainer. labels Apr 10, 2019
resmo
resmo approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thedoubl3j
thedoubl3j approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the tests. shipit

@thedoubl3j thedoubl3j merged commit e12846f into ansible:devel Apr 11, 2019
@carchi8py carchi8py mentioned this pull request May 3, 2019
Closed
@lonico
Copy link
Contributor

lonico commented May 30, 2019

close #51445

@lonico
Copy link
Contributor

lonico commented May 30, 2019

close #51441

@thedoubl3j
Copy link
Member

@lonico this PR address those issues?

@lonico
Copy link
Contributor

lonico commented Jun 2, 2019

@thedoubl3j yes it does

@thedoubl3j thedoubl3j mentioned this pull request Jun 3, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@lonico lonico lonico approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carchi8py @ansibot @lonico @thedoubl3j @resmo