Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to examples and error for NVME #54803

Merged
merged 1 commit into from
Apr 10, 2019
Merged

update to examples and error for NVME #54803

merged 1 commit into from
Apr 10, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

update to examples and error for NVME

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • na_ontap_nvme.py
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 3, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. storage support:certified This issue/PR relates to certified code. labels Apr 3, 2019
lonico
lonico approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed committer_review In order to be merged, this PR must follow the certified review workflow. needs_triage Needs a first human triage before being processed. labels Apr 3, 2019
gundalow
gundalow reviewed Apr 10, 2019
View reviewed changes
lib/ansible/modules/storage/netapp/na_ontap_nvme.py
type: bool
short_description: "NetApp ONTAP Manage NVMe Service"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, modules go:
module, short_description, description, options,...

@gundalow gundalow merged commit 6661f17 into ansible:devel Apr 10, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

@lonico lonico lonico approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. netapp owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carchi8py @ansibot @gundalow @lonico