Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming azure_rm_managed_disk for consistency #54825

Merged
merged 3 commits into from
Apr 4, 2019

Conversation

zikalino
Copy link
Contributor

@zikalino zikalino commented Apr 4, 2019

SUMMARY

This change removes extra underscore in 2 module names

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_manageddisk
azure-rm_manageddisk_facts

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

@zikalino this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 azure bug This issue/PR relates to a bug. cloud deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Apr 4, 2019
@@ -524,9 +524,9 @@ groupings:
- azure
azure_rm_loadbalancer_facts:
- azure
azure_rm_managed_disk:
azure_rm_manageddisk:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what 's this file used for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the purpose of this file is to assign modules to groups.

And then user could use module_defaults like described here https://docs.ansible.com/ansible/latest/user_guide/playbooks_module_defaults.html
on group/azure for all azure modules, like this:

  • hosts: localhost
    module_defaults:
    group/azure:
    location: eastus
    tasks:
    • azure_rm_xxxx:

But that doesn't seem to be very common feature, and I think it's not maintained very well.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 4, 2019
@zikalino zikalino merged commit 69ca898 into ansible:devel Apr 4, 2019
@zikalino zikalino deleted the rename-managed-disk branch April 4, 2019 04:24
@jeking3
Copy link
Contributor

jeking3 commented Apr 4, 2019

You changed the name of azure_rm_managed_disk to azure_rm_manageddisk? Isn't that a breaking change? Every playbook that uses one of these is going to fail?

@mattclay
Copy link
Member

mattclay commented Apr 4, 2019

@jeking3 Aliases were added for the old module names, so they will continue to work.

@jeking3
Copy link
Contributor

jeking3 commented Apr 4, 2019

Okay, phew! Thanks, I missed that in my panic. :)

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure bug This issue/PR relates to a bug. cloud deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants