-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming azure_rm_managed_disk for consistency #54825
Conversation
@zikalino this PR contains more than one new module. Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation |
@@ -524,9 +524,9 @@ groupings: | |||
- azure | |||
azure_rm_loadbalancer_facts: | |||
- azure | |||
azure_rm_managed_disk: | |||
azure_rm_manageddisk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what 's this file used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the purpose of this file is to assign modules to groups.
And then user could use module_defaults like described here https://docs.ansible.com/ansible/latest/user_guide/playbooks_module_defaults.html
on group/azure for all azure modules, like this:
- hosts: localhost
module_defaults:
group/azure:
location: eastus
tasks:- azure_rm_xxxx:
But that doesn't seem to be very common feature, and I think it's not maintained very well.
You changed the name of azure_rm_managed_disk to azure_rm_manageddisk? Isn't that a breaking change? Every playbook that uses one of these is going to fail? |
@jeking3 Aliases were added for the old module names, so they will continue to work. |
Okay, phew! Thanks, I missed that in my panic. :) |
SUMMARY
This change removes extra underscore in 2 module names
ISSUE TYPE
COMPONENT NAME
azure_rm_manageddisk
azure-rm_manageddisk_facts
ADDITIONAL INFORMATION