Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding missing Azure facts modules #54838

Merged
merged 5 commits into from
Apr 11, 2019
Merged

adding missing Azure facts modules #54838

merged 5 commits into from
Apr 11, 2019

Conversation

zikalino
Copy link
Contributor

@zikalino zikalino commented Apr 4, 2019 •
edited

SUMMARY

Several modules for DTL

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_devtestlabschedule_facts
azure_rm_devtestlabpolicy_facts
azure_rm_devtestlavenvironment_facts
azure_rm_devtestlabcustomimage_facts

ADDITIONAL INFORMATION

Currently DTL Tests are disabled, so the modules were tested manually.

@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

@zikalino this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 azure cloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/cloud/azure/azure_rm_devtestlabpolicy_facts.py:0:0: E322 Argument 'expand' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_devtestlabpolicy_facts.py:0:0: E322 Argument 'tags' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_devtestlabschedule_facts.py:0:0: E322 Argument 'expand' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_devtestlabschedule_facts.py:0:0: E322 Argument 'tags' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster_facts.py:106:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Apr 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_devtestlabpolicy_facts.py:165:54: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabpolicy_facts.py:166:54: E128 continuation line under-indented for visual indent

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster_facts.py:106:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@zikalino zikalino changed the title [WIP] adding missing Azure facts modules adding missing Azure facts modules Apr 4, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. ci_verified Changes made in this PR are causing tests to fail. labels Apr 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_devtestlabpolicy_facts.py:194:54: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabpolicy_facts.py:195:54: E128 continuation line under-indented for visual indent

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_devtestlabcustomimage_facts.py:67:1: key-duplicates RETURN: duplication of key "custom_images" in mapping

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Apr 4, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 4, 2019
@zikalino zikalino requested a review from yungezz April 4, 2019 14:10
yungezz
yungezz reviewed Apr 8, 2019
View reviewed changes
Copy link
Contributor

@yungezz yungezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general good, some comments

lib/ansible/modules/cloud/azure/azure_rm_devtestlabcustomimage_facts.py Outdated
pass


class AzureRMCustomImageFacts(AzureRMModuleBase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevTestLabCustomImage?

lib/ansible/modules/cloud/azure/azure_rm_devtestlabenvironment_facts.py Outdated
pass


class AzureRMEnvironmentFacts(AzureRMModuleBase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class name with devtestlab?

lib/ansible/modules/cloud/azure/azure_rm_devtestlabcustomimage_facts.py
type: str
sample: "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxxx//resourcegroups/myResourceGroup/providers/microsoft.devtestlab/labs/myLab/v
irtualmachines/myLabVm"
tags:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has tags, can facts be filtered by tags?

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 8, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request Apr 10, 2019
Closed
@Fred-sun
Copy link
Contributor

@zikalino Need you update according by the comments! Thanks!

@zikalino
Copy link
Contributor Author

@yungezz added "Dtl" to class names, also added facts.
performed all manual tests

@yungezz
Copy link
Contributor

yungezz commented Apr 11, 2019

@yungezz added "Dtl" to class names, also added facts.
performed all manual tests

seems you didn't push

@zikalino zikalino merged commit 62f4eb7 into ansible:devel Apr 11, 2019
@zikalino zikalino deleted the missing-facts-modules branch April 11, 2019 03:46
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yungezz yungezz yungezz approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zikalino @ansibot @Fred-sun @yungezz