Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_idx: added CI tests for check_mode, rewrite code related with check_mode, misc fixes #54848

Merged
merged 2 commits into from
Apr 4, 2019
Merged

postgresql_idx: added CI tests for check_mode, rewrite code related with check_mode, misc fixes #54848

merged 2 commits into from
Apr 4, 2019

Conversation

Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented Apr 4, 2019 •
edited

SUMMARY
  • added CI tests for check_mode
  • rewrite code related with check_mode (it became safer)
  • misc fixes
  • added aliase

check_mode used rollback, this behavior has been changed by this PR.
Now it won't build indexes and rollback them, just checks indexes exist or not (it doesn't actually affect a database, so safer when databases are highly loaded and tables are big)

ISSUE TYPE
  • Docs Pull Request

@Andersson007 Andersson007 force-pushed the postgresql_idx_improved_tests branch from eff0c33 to 85210a6 Compare April 4, 2019 11:27
@Andersson007 Andersson007 reopened this Apr 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

cc @Dorn- @amenonsen @andytom @jbscalia @kostiantyn-nemchenko @kustodian @matburt @nerzhul @sebasmannem
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. database Database category docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Apr 4, 2019
@Andersson007 Andersson007 reopened this Apr 4, 2019
@Andersson007 Andersson007 reopened this Apr 4, 2019
@Andersson007 Andersson007 reopened this Apr 4, 2019
@gundalow gundalow merged commit 2fbac89 into ansible:devel Apr 4, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 9, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. database Database category docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Andersson007 @ansibot @gundalow @sivel