Module validation: don't complain if type() is used in if #54849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
sivel
approved these changes
Apr 9, 2019
|
@sivel thanks for merging this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
Type comparison using type() found. Use isinstance() insteadcondition is too strict, it also has a problem with things likeif self.key.type() == crypto.TYPE_RSA:, which has nothing to do with type comparisons. This improves the check by making sure thatcheck()is ignored, onlycheck(followed by something else than)is considered. This still can cause false negatives, but fewer of them.ISSUE TYPE
COMPONENT NAME
test/sanity/validate-modules/main.py