Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudscale_server: implement param server_groups #54868

Merged
merged 4 commits into from
Apr 10, 2019
Merged

cloudscale_server: implement param server_groups #54868

merged 4 commits into from
Apr 10, 2019

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Apr 4, 2019

SUMMARY

Implement new param server_groups, deprecates anti_affinity_with

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cloudscale_server

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/cloudscale/cloudscale_server.py:244:161: E501 line too long (172 > 160 characters)

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/cloudscale/cloudscale_server.py:0:0: E305 DOCUMENTATION.options.anti_affinity_with.deprecated: extra keys not allowed @ data['options']['anti_affinity_with']['deprecated']. Got '2.11'
lib/ansible/modules/cloud/cloudscale/cloudscale_server.py:0:0: E309 version_added for new option (server_groups) should be '2.8'. Currently StrictVersion ('0.0')
lib/ansible/modules/cloud/cloudscale/cloudscale_server.py:0:0: E319 RETURN.anti_affinity_with.deprecated: extra keys not allowed @ data['anti_affinity_with']['deprecated']. Got '2.11'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

cc @gaudenz
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 ci_verified Changes made in this PR are causing tests to fail. cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. community_review In order to be merged, this PR must follow the community review workflow. test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. owner_pr This PR is made by the module's maintainer. labels Apr 4, 2019
gaudenz
gaudenz suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@gaudenz gaudenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. Beside the problem with duplicate names, I think we should extend the test coverage a bit. Maybe it's easiest to rebase this branch onto the cloudscale_server_group branch. Without the cloudscale_server_group module this change is pretty useless anyway.

lib/ansible/modules/cloud/cloudscale/cloudscale_server.py Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Apr 9, 2019
@resmo
Copy link
Contributor Author

resmo commented Apr 10, 2019

ready_for_review

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 10, 2019
@resmo
Copy link
Contributor Author

resmo commented Apr 10, 2019

rebased

@resmo resmo merged commit e28d08a into ansible:devel Apr 10, 2019
@resmo resmo deleted the feature/cloudscale_server_add_server_groups branch April 10, 2019 22:16
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaudenz gaudenz gaudenz requested changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@resmo @ansibot @gaudenz