Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example in iptables module #54906

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Fix example in iptables module #54906

merged 1 commit into from
Apr 5, 2019

Conversation

stzilli
Copy link
Contributor

@stzilli stzilli commented Apr 5, 2019

SUMMARY

In the documentation the rule_num parameter works only in conjunction with action set to insert but in the example action is not defined so the default append value is used.

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

iptables

ADDITIONAL INFORMATION

N/A

@stzilli
Fix example in iptables module
529f1c8 
In the documentation the rule_num parameter works only in conjunction with action set to insert but in the example action is not defined so the default append value is used.

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Apr 5, 2019

cc @LinusU @sebastiendarocha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category labels Apr 5, 2019
@acozine
Copy link
Contributor

acozine commented Apr 5, 2019

Thanks for catching that @stzilli!

@acozine acozine merged commit fa21e0c into ansible:devel Apr 5, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 9, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stzilli @ansibot @acozine @sivel