Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl_certificate_info, openssl_csr: fix wrong exception, and little refactoring #54922

Merged
merged 2 commits into from
Apr 5, 2019
Merged

openssl_certificate_info, openssl_csr: fix wrong exception, and little refactoring #54922

merged 2 commits into from
Apr 5, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fixes use of the wrong exception name in openssl_certificate_info, and makes openssl_csr always use crypto_utils.load_certificate_request().

Both changes get no changelog since they affect code new for 2.8.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openssl_certificate_info
openssl_csr

@ansibot
Copy link
Contributor

ansibot commented Apr 5, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @puiterwijk @resmo
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 5, 2019
@resmo
Copy link
Contributor

resmo commented Apr 5, 2019

LGTM

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Apr 5, 2019
@ansibot ansibot merged commit c5991b9 into ansible:devel Apr 5, 2019
@felixfontein felixfontein deleted the openssl_certificate_info-fix-and-little-changes branch April 5, 2019 20:20
@felixfontein
Copy link
Contributor Author

@resmo thanks for reviewing!

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixfontein @ansibot @resmo