-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify how to use variables with handlers #54928
Merged
acozine
merged 8 commits into
ansible:devel
from
samdoran:issue/19050-handler-names-not-templated
Apr 11, 2019
Merged
Clarify how to use variables with handlers #54928
acozine
merged 8 commits into
ansible:devel
from
samdoran:issue/19050-handler-names-not-templated
Apr 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
This issue/PR affects Ansible v2.8
core_review
In order to be merged, this PR must follow the core review workflow.
docs
This issue/PR relates to or includes documentation.
needs_triage
Needs a first human triage before being processed.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Apr 5, 2019
Add example on how to use variables in handlers
samdoran
force-pushed
the
issue/19050-handler-names-not-templated
branch
from
April 5, 2019 21:33
bd4fe9c
to
e8352bd
Compare
Akasurde
reviewed
Apr 6, 2019
ansibot
removed
the
needs_triage
Needs a first human triage before being processed.
label
Apr 6, 2019
mkrizek
reviewed
Apr 8, 2019
bcoca
reviewed
Apr 10, 2019
mkrizek
approved these changes
Apr 11, 2019
acozine
reviewed
Apr 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes that extend the example to a don't do this / do this instead pattern.
Co-Authored-By: samdoran <sdoran@redhat.com>
Co-Authored-By: samdoran <sdoran@redhat.com>
Co-Authored-By: samdoran <sdoran@redhat.com>
Co-Authored-By: samdoran <sdoran@redhat.com>
acozine
reviewed
Apr 11, 2019
acozine
reviewed
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.8
This issue/PR affects Ansible v2.8
core_review
In order to be merged, this PR must follow the core review workflow.
docs
This issue/PR relates to or includes documentation.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #19050
Handler names cannot use variables. Clarify this in the docs and add an example on where and how to user variables appropriately in handlers.
ISSUE TYPE
COMPONENT NAME
/docs/docsite/rst/user_guide/playbooks_intro.rst