Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to use variables with handlers #54928

Merged

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Apr 5, 2019

SUMMARY

Fixes #19050

Handler names cannot use variables. Clarify this in the docs and add an example on where and how to user variables appropriately in handlers.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

/docs/docsite/rst/user_guide/playbooks_intro.rst

@ansibot
Copy link
Contributor

ansibot commented Apr 5, 2019

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 5, 2019
Add example on how to use variables in handlers
@samdoran samdoran force-pushed the issue/19050-handler-names-not-templated branch from bd4fe9c to e8352bd Compare April 5, 2019 21:33
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 6, 2019
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes that extend the example to a don't do this / do this instead pattern.

docs/docsite/rst/user_guide/playbooks_intro.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_intro.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_intro.rst Outdated Show resolved Hide resolved
acozine and others added 5 commits April 11, 2019 11:03
Co-Authored-By: samdoran <sdoran@redhat.com>
Co-Authored-By: samdoran <sdoran@redhat.com>
Co-Authored-By: samdoran <sdoran@redhat.com>
Co-Authored-By: samdoran <sdoran@redhat.com>
@acozine acozine merged commit f7ed194 into ansible:devel Apr 11, 2019
@samdoran samdoran deleted the issue/19050-handler-names-not-templated branch April 12, 2019 21:15
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling handlers with parameters does not work in many cases
6 participants