Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callback/cgroup_perf_recap: Add options for configuring memory / pid polling interval #54936

Merged
merged 1 commit into from
Apr 8, 2019
Merged

callback/cgroup_perf_recap: Add options for configuring memory / pid polling interval #54936

merged 1 commit into from
Apr 8, 2019

Conversation

jladdjr
Copy link
Contributor

@jladdjr jladdjr commented Apr 6, 2019

SUMMARY

Add options for configuring memory / pid polling interval in cgroup_perf_recap plugin.

Related: #46346

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cgroup_perf_recap

ADDITIONAL INFORMATION

As written, the plugin polls memory / pids every .01 seconds. This lets the user pick a less granular polling interval if needed.

cc @sivel

@jladdjr
Copy link
Contributor Author

jladdjr commented Apr 6, 2019 •
edited

This change is in support of ansible/awx#3609

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 6, 2019
@gundalow gundalow changed the title Add options for configuring memory / pid polling interval callback/cgroup_perf_recap: Add options for configuring memory / pid polling interval Apr 7, 2019
@sivel sivel self-assigned this Apr 8, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 8, 2019
@sivel sivel merged commit 17d7855 into ansible:devel Apr 8, 2019
@jladdjr
Copy link
Contributor Author

jladdjr commented Apr 8, 2019

Thanks @sivel!

ryanpetrello added a commit to jladdjr/ansible-runner that referenced this pull request Apr 9, 2019
@ryanpetrello
implement perf plugin interval flags for memory and pid
174b692 
see: ansible/ansible#54936
ryanpetrello added a commit to jladdjr/ansible-runner that referenced this pull request Apr 9, 2019
@ryanpetrello
implement perf plugin interval flags for memory and pid
056580d 
see: ansible/ansible#54936
jladdjr pushed a commit to jladdjr/ansible-runner that referenced this pull request Apr 10, 2019
@ryanpetrello
implement perf plugin interval flags for memory and pid
e493a0b 
see: ansible/ansible#54936
jladdjr pushed a commit to jladdjr/ansible-runner that referenced this pull request Apr 24, 2019
@ryanpetrello
implement perf plugin interval flags for memory and pid
1f6b762 
see: ansible/ansible#54936
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

Assignees

@sivel sivel

Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jladdjr @sivel @ansibot