Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_container: improve log_options idempotency by converting to string #54955

Merged
merged 6 commits into from
Apr 12, 2019
Merged

docker_container: improve log_options idempotency by converting to string #54955

merged 6 commits into from
Apr 12, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Also prints warning when value is not a string. Fixes #54954.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_container

@felixfontein felixfontein mentioned this pull request Apr 7, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Apr 7, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @cove @danihodovic @dariko @dusdanig @joshuaconner @jwitko @kassiansun @softzilla @tbouvet @zfil
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 7, 2019
@felixfontein felixfontein mentioned this pull request Apr 8, 2019
Closed
5 tasks
@felixfontein
Copy link
Contributor Author

If nobody complains til Thursday, I'll merge this.

Andersson007
Andersson007 approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

(are there any ci tests for this module to be sure that nothing will break down even if changes are small?)

@ansibot ansibot added test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 12, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 12, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 12, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 12, 2019
@felixfontein
Copy link
Contributor Author

Test has been added and works (both on CI and locally).

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 12, 2019
@ansibot ansibot added the shipit This PR is ready to be merged by Core label Apr 12, 2019
@ansibot ansibot merged commit d64b177 into ansible:devel Apr 12, 2019
@felixfontein
Copy link
Contributor Author

@Andersson007 thank you very much for reviewing this!

@felixfontein felixfontein deleted the docker_container-log_options-strings branch April 12, 2019 22:46
felixfontein added a commit to felixfontein/ansible that referenced this pull request Apr 12, 2019
@felixfontein
docker_container: improve log_options idempotency by converting to st…
9dd31c5 
…ring (ansible#54955)

* Warn when log_options values are not strings.

* Add changelog.

* Improve message.

* Improve formatting and formulation of other messages.

* Add test for warning.

* Trying double escaping.

(cherry picked from commit d64b177)
felixfontein added a commit to felixfontein/ansible that referenced this pull request Apr 12, 2019
@felixfontein
docker_container: improve log_options idempotency by converting to st…
ab7df2a 
…ring (ansible#54955)

* Warn when log_options values are not strings.

* Add changelog.

* Improve message.

* Improve formatting and formulation of other messages.

* Add test for warning.

* Trying double escaping.

(cherry picked from commit d64b177)
This was referenced Apr 12, 2019
Merged
Merged
abadger pushed a commit that referenced this pull request Apr 16, 2019
@felixfontein @abadger
docker_container: improve log_options idempotency by converting to st…
f27481a 
…ring (#54955)

* Warn when log_options values are not strings.

* Add changelog.

* Improve message.

* Improve formatting and formulation of other messages.

* Add test for warning.

* Trying double escaping.

(cherry picked from commit d64b177)
abadger pushed a commit that referenced this pull request Apr 16, 2019
@felixfontein @abadger
docker_container: improve log_options idempotency by converting to st…
ebc717c 
…ring (#54955)

* Warn when log_options values are not strings.

* Add changelog.

* Improve message.

* Improve formatting and formulation of other messages.

* Add test for warning.

* Trying double escaping.

(cherry picked from commit d64b177)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker_container log_driver and log_options cause container recreation (always)
4 participants
@felixfontein @ansibot @Andersson007 @mattclay