Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The module fails on switchport. Check added to fix. #54970

Merged
merged 1 commit into from
Apr 8, 2019
Merged

The module fails on switchport. Check added to fix. #54970

merged 1 commit into from
Apr 8, 2019

Conversation

amuraleedhar
Copy link
Contributor

SUMMARY

Fixing a bug on cnos_vrf module to check if port is configured as switchport

ISSUE TYPE
  • Bug Fix Pull Request
COMPONENT NAME

lib/ansible/modules/network/cnos/cnos_vrf.py
test/integration/targets/cnos_vrf/tests/cli/basic.yaml
test/units/modules/network/cnos/test_cnos_vrf.py

ANSIBLE VERSION

ansible 2.8.0.dev0 (devel e2b9c36) last updated 2018/10/12 13:58:41 (GMT +550)
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/ansible/sheru/ansible/lib/ansible
executable location = /home/ansible/sheru/ansible/bin/ansible
python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]

ADDITIONAL INFORMATION

Unit Test and Integration tests are also successfully tested with CNOS G8272 with image version 10.9.1

@ansibot
Copy link
Contributor

ansibot commented Apr 8, 2019

cc @NilashishC @Qalthos @dkasberg @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Apr 8, 2019
@amuraleedhar amuraleedhar mentioned this pull request Apr 8, 2019
Closed
@justjais justjais merged commit f5d9720 into ansible:devel Apr 8, 2019
@amuraleedhar
Copy link
Contributor Author

Thank You !!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 9, 2019
@amuraleedhar amuraleedhar deleted the lenovo-cnos-vrf-bugfix branch June 11, 2019 07:14
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justjais justjais justjais approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amuraleedhar @ansibot @justjais @sivel