Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed SafeConfigParser to ConfigParser #54974

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Renamed SafeConfigParser to ConfigParser #54974

merged 1 commit into from
Apr 10, 2019

Conversation

junjihashimoto
Copy link
Contributor

SUMMARY

Rename SafeConfigParser to ConfigParser in inventory/gce.py.
Because DeprecationWarning happens in python3.2 or later.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

GCP-plugin

ADDITIONAL INFORMATION
$ ansible-playbook xxx.yml -l xxx
xxx/inventory/gce.py:213: DeprecationWarning: The SafeConfigParser class has been renamed to ConfigParser
in Python 3.2. This alias will be removed in future versions. Use ConfigParser directly instead.   'cache_max_age': '300'
...

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. c:inventory/contrib_script community_review In order to be merged, this PR must follow the community review workflow. inventory Inventory category needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. python3 small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Apr 8, 2019
@Akasurde
Copy link
Member

Akasurde commented Apr 9, 2019

@samdoran Does PR #55000 solve this as well ? Thanks.

@samdoran
Copy link
Contributor

samdoran commented Apr 9, 2019

@Akasurde No, #55000 does not fix the problem this PR is fixing.

@samdoran
Copy link
Contributor

samdoran commented Apr 9, 2019

Please create a changelog fragment. See this fragment as an example.

@junjihashimoto
Copy link
Contributor Author

@samdoran
Thank you for your reviewing.
Add a fragment-file.

@samdoran samdoran merged commit c3e50db into ansible:devel Apr 10, 2019
@junjihashimoto junjihashimoto deleted the fix/safeconfigparser branch April 11, 2019 05:25
@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Apr 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. c:inventory/contrib_script community_review In order to be merged, this PR must follow the community review workflow. inventory Inventory category new_contributor This PR is the first contribution by a new community member. python3 support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@junjihashimoto @Akasurde @samdoran @mkrizek @ansibot