Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Add check for valid VLAN id range #55023

Merged
merged 1 commit into from Apr 10, 2019
Merged

VMware: Add check for valid VLAN id range #55023

merged 1 commit into from Apr 10, 2019

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Apr 9, 2019

SUMMARY

Check allows vmware_dvs_portgroup to fail early if user
specified invalid range in VLAN id(s).

Fixes: #54927

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_dvs_portgroup.py
test/integration/targets/vmware_dvs_portgroup/tasks/main.yml

@Akasurde
VMware: Add check for valid VLAN id range
3a9c5ef 
Check allows vmware_dvs_portgroup to fail early if user
specified invalid range in VLAN id(s).

Fixes: ansible#54927

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Apr 9, 2019

cc @Tomorrow9 @ckotte @dav1x @lparkes @pdellaert @warthog9
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Apr 9, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Apr 9, 2019
@Akasurde
Copy link
Member Author

Akasurde commented Apr 9, 2019

cc @MikeySm

@Akasurde Akasurde mentioned this pull request Apr 9, 2019
Closed
@goneri
Copy link
Contributor

goneri commented Apr 9, 2019

shipit

pdellaert
pdellaert approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@pdellaert pdellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 9, 2019
@Akasurde Akasurde merged commit 98692ab into ansible:devel Apr 10, 2019
@Akasurde Akasurde deleted the i54927 branch April 10, 2019 02:39
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pdellaert pdellaert pdellaert approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VMware: vmware_dvs_portgroup: range in vlan_id does not work
4 participants
@Akasurde @ansibot @goneri @pdellaert