Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the documentation for the ip_tags #55069

Merged
merged 4 commits into from
Apr 10, 2019
Merged

add the documentation for the ip_tags #55069

merged 4 commits into from
Apr 10, 2019

Conversation

Fred-sun
Copy link
Contributor

@Fred-sun Fred-sun commented Apr 10, 2019 •
edited

SUMMARY

Add the documentation for the azure_rm_publicipaddress's ip_tags

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

azure_rm_publicipaddress.py

ADDITIONAL INFORMATION

@Fred-sun
Copy link
Contributor Author

@yuwzho I have added the documentation for the azure_rm_publicipaddress's ip_tags. Please review! Thanks!

@ansibot
Copy link
Contributor

ansibot commented Apr 10, 2019

@Fred-sun this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 azure cloud docs This issue/PR relates to or includes documentation. merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 10, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 10, 2019

cc @haroldwongms @nitzmahone @trstringer @xscript @zikalino
click here for bot help

@ansibot ansibot added small_patch and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Apr 10, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request Apr 10, 2019
Closed
yuwzho
yuwzho suggested changes Apr 10, 2019
View reviewed changes
lib/ansible/modules/cloud/azure/azure_rm_publicipaddress.py Outdated
@@ -75,6 +75,11 @@
description:
- List of IpTag associated with the public IP address.
- Each element should contain type:value pair.
suboptions:
type:
description: Sets the ip_tags type: Example FirstPartyUsage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an invalid yaml.

We usually write the description as a list. BTW, there is no need to add the example. if there is ":" in the sentence, the whole line should be quoted.

description:
    - "XXXXX"

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 10, 2019
@Fred-sun
Copy link
Contributor Author

@yuwzho I submitted the new changed, but the shippable check is wrong, without any hint? Could you please help to check the problem? Thanks!

@tao12345666333
Copy link
Contributor

After CI goes green you need squash your commits.

@zikalino
Copy link
Contributor

@tao12345666333 no need to squash now, will be squashed while merging the pr.

@Fred-sun
Copy link
Contributor Author

ready_for_review

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 10, 2019
@yuwzho
Copy link
Contributor

yuwzho commented Apr 10, 2019

shipit

@zikalino zikalino merged commit 44c2061 into ansible:devel Apr 10, 2019
@tao12345666333
Copy link
Contributor

@tao12345666333 no need to squash now, will be squashed while merging the pr.

Thank you for reminding. 👍 @zikalino

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tao12345666333 tao12345666333 tao12345666333 requested changes

@yuwzho yuwzho yuwzho approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fred-sun @ansibot @tao12345666333 @zikalino @yuwzho