Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Added update_netbox_object to netbox_ip_address #55070

Merged
merged 1 commit into from
Apr 10, 2019
Merged

BugFix: Added update_netbox_object to netbox_ip_address #55070

merged 1 commit into from
Apr 10, 2019

Conversation

FragmentedPacket
Copy link
Contributor

SUMMARY

I missed adding the update_netbox_object on previous PR (#53631)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

netbox_ip_address

ADDITIONAL INFORMATION

Below output is what current behavior is:

TASK [Update 192.168.1.10/30] *************************************************************************************************************************************************************************************************************************************************ok: [localhost] => changed=false
  ip_address:
    address: 192.168.1.10/30
    created: '2019-04-10'
    custom_fields: {}
    description: ''
    family: 4
    id: 7
    interface: null
    last_updated: '2019-04-10T02:33:27.908274Z'
    nat_inside: null
    nat_outside: null
    role: null
    status: 1
    tags: []
    tenant: null
    vrf: null
  msg: IP Address 192.168.1.10/30 already exists

Below is the output after adding the update functionality

TASK [Update 192.168.1.10/30] ********************************************************************************************************
changed: [localhost] => changed=true
  ip_address:
    address: 192.168.1.10/30
    created: '2019-04-10'
    custom_fields: {}
    description: Updated ip address
    family: 4
    id: 34
    interface: null
    last_updated: '2019-04-10T02:58:22.903735Z'
    nat_inside: null
    nat_outside: null
    role: null
    status: 1
    tags:
    - Updated
    tenant: null
    vrf: null
  msg: IP Address 192.168.1.10/30 updated

@ansibot
Copy link
Contributor

ansibot commented Apr 10, 2019

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 10, 2019
@gundalow gundalow merged commit 0b5b353 into ansible:devel Apr 10, 2019
@gundalow
Copy link
Contributor

@FragmentedPacket Thank you!
This module is new in 2.8, so no need for changelog or to backport

Merged into devel

@FragmentedPacket
Copy link
Contributor Author

@gundalow thanks for getting it merged so fast!

@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Apr 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. net_tools Net-tools category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants