Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hcloud testsuite #55076

Merged
merged 6 commits into from
Apr 10, 2019
Merged

Fix hcloud testsuite #55076

merged 6 commits into from
Apr 10, 2019

Conversation

LKaemmerling
Copy link
Contributor

SUMMARY

This PR fixes some more of our tests when running concurrently.

ISSUE TYPE
  • Test Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 10, 2019

cc @cschmitt-hcloud @LKaemmerling
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud hcloud needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 10, 2019
@LKaemmerling
Improve tests
ad764d0
@LKaemmerling
Fix hcloud testsuite and activate all tests
3f27055 
Increase default limit on resize server
Fix typo in hcloud_volume_facts
@ansibot ansibot added module This issue/PR relates to a module. small_patch labels Apr 10, 2019
@LKaemmerling LKaemmerling changed the title [WIP] Fix hcloud tests Fix hcloud testsuite Apr 10, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Apr 10, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 10, 2019
@gundalow @LKaemmerling
Update test/integration/targets/hcloud_floating_ip_facts/tasks/main.yml
67352b3 
Co-Authored-By: LKaemmerling <4281581+LKaemmerling@users.noreply.github.com>
resmo
resmo approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@resmo resmo merged commit 3f579eb into ansible:devel Apr 10, 2019
@LKaemmerling LKaemmerling deleted the fix_hcloud_tests branch April 10, 2019 13:25
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. hcloud module This issue/PR relates to a module. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LKaemmerling @ansibot @resmo @gundalow