Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding New Model for Configure Buffer Pool on Onyx Switches #55082

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Adding New Model for Configure Buffer Pool on Onyx Switches #55082

merged 2 commits into from
Apr 11, 2019

Conversation

anasbadaha
Copy link
Contributor

Signed-off-by: Anas Badaha anasb@mellanox.com

SUMMARY

Adding New Model for Configure Buffer Pool on Onyx Switches

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/network/onyx/onyx_buffer_pool.py
test/units/modules/network/onyx/fixtures/onyx_buffer_pool.cfg
test/units/modules/network/onyx/test_onyx_buffer_pool.py

ADDITIONAL INFORMATION
ansible 2.8.0a1.post0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /.autodirect/mtrswgwork/anasb/ansible_dev8/lib/ansible
  executable location = /.autodirect/mtrswgwork/anasb/ansible_dev8/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

@anasbadaha
Adding New Model for Configure Buffer Pool on Onyx Switches
b44fd2b 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@ansibot
Copy link
Contributor

ansibot commented Apr 10, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @samerd @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 10, 2019
@anasbadaha
Fix Pep8 Failures in onyx_buffer_pool.py
395b211 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 10, 2019
@justjais
Copy link
Contributor

cc. @gundalow

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 10, 2019
@anasbadaha
Copy link
Contributor Author

Hi @samerd,

Please review the following PR and let me know if you have any comments.

Thanks

samerd
samerd approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@samerd samerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job Anas.

@justjais justjais merged commit 9bd0602 into ansible:devel Apr 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samerd samerd samerd approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anasbadaha @ansibot @justjais @samerd