adding facts for Azure HDINsight cluster #55124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungezz
reviewed
Apr 11, 2019
| self.results['clusters'] = self.get() | ||
| elif self.resource_group is not None: | ||
| self.results['clusters'] = self.list_all() | ||
| return self.results |
There was a problem hiding this comment.
what if else? return hdinsight in current subs?
There was a problem hiding this comment.
seems by resource group you should be list_by_resource_group() else list_all()
ansibot
added
affects_2.8
added 2 commits
April 11, 2019 14:31
yungezz
approved these changes
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding missing facts module
ISSUE TYPE
COMPONENT NAME
azure_rm_hdinsightcluster_facts
ADDITIONAL INFORMATION