Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding New Model onyx_qos for Configuring QoS on Onyx Switches #55127

Merged
merged 6 commits into from
May 17, 2019
Merged

Adding New Model onyx_qos for Configuring QoS on Onyx Switches #55127

merged 6 commits into from
May 17, 2019

Conversation

anasbadaha
Copy link
Contributor

Signed-off-by: Anas Badaha anasb@mellanox.com

SUMMARY

Adding New Model onyx_qos for Configuring QoS on Onyx Switches

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/network/onyx/onyx_qos.py
test/units/modules/network/onyx/fixtures/show_qos_interface_ethernet.cfg
test/units/modules/network/onyx/test_onyx_qos.py

ADDITIONAL INFORMATION
ansible 2.8.0a1.post0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /.autodirect/mtrswgwork/anasb/ansible_dev8/lib/ansible
  executable location = /.autodirect/mtrswgwork/anasb/ansible_dev8/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

@ansibot
Copy link
Contributor

ansibot commented Apr 11, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @samerd @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 11, 2019
@anasbadaha
Copy link
Contributor Author

Hi @samerd,

Please take a look on this PR and approve it if you don't have farther comments.

Thanks

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 11, 2019
samerd
samerd suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@samerd samerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anas.
excellent module.
However, I have few minor comments:
1- rewrite_dscp and rewrite_pcp, should be both disabled by default
2- regarding the "no" commands, although your commands are working, I prefer to put the no before the qos, instead before the interface
NO_REWRITE_PCP_CMD = "interface {0} {1} no qos rewrite pcp"
NO_REWRITE_DSCP_CMD = "interface {0} {1} no qos rewrite dscp"

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Apr 11, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 14, 2019

@anasbadaha this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added the merge_commit This PR contains at least one merge commit. Please resolve! label Apr 14, 2019
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 14, 2019
@anasbadaha
Copy link
Contributor Author

Hi @samerd ,

I have fixed all your comments, please approve if it's OK for you.

Thanks

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 15, 2019
@samerd
Copy link
Contributor

samerd commented Apr 16, 2019

@justjais
please review and merge if OK with you

@samerd samerd mentioned this pull request Apr 22, 2019
Closed
@anasbadaha
Copy link
Contributor Author

Hi @justjais,

Can you please merge this PR if it is OK for you?

Thanks

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 23, 2019
@ganeshrn
Copy link
Member

rebuild_merge

@ganeshrn
Copy link
Member

@anasbadaha The PR has merge commit. Please rebase it.

@anasbadaha
Adding New Model onyx_qos for Configuring QoS on Onyx Switches
2d7e928 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@anasbadaha
Fix Pep8 Failures in onyx_qos
a82d10f 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@anasbadaha
Fix Pep8 Failures phase 2
f704de6 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@anasbadaha
Fix Samer's Comments on onyx_qos Module
7fe9db1 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@anasbadaha
Fix Shippable Comments Phase 3
feb4058 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@anasbadaha
Fix Current Version 2.9
6c971ff 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@anasbadaha
Copy link
Contributor Author

anasbadaha commented May 14, 2019 •
edited

Hi @ganeshrn @samerd:

I have rebased it, please merge!

Thanks

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 14, 2019
@ganeshrn
Copy link
Member

@anasbadaha Thank you!

@ganeshrn ganeshrn merged commit 5a7bce1 into ansible:devel May 17, 2019
@samerd
Copy link
Contributor

samerd commented May 17, 2019

Thanks so much @ganeshrn

@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@samerd samerd samerd approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anasbadaha @ansibot @samerd @ganeshrn