Fix in function app #55134
Merged
Fix in function app #55134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungezz
reviewed
Apr 11, 2019
| function_app_settings.append(NameValuePair(name='WEBSITE_NODE_DEFAULT_VERSION', value='6.5.0')) | ||
| function_app_settings.append(NameValuePair(name='WEBSITE_CONTENTSHARE', value=self.name)) | ||
| else: | ||
| function_app_settings.append(NameValuePair(name='FUNCTIONS_EXTENSION_VERSION', value='~2')) |
There was a problem hiding this comment.
seems original default is ~1. is the upgrade intended?
There was a problem hiding this comment.
container based function apps need version ~2 so we may just assume ~2 is needed, otherwise user will have to specify anyway
yungezz
approved these changes
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Container based function app don't need some settings.
ISSUE TYPE
COMPONENT NAME
azure_rm_functionapp
ADDITIONAL INFORMATION