Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a title to the installation guide #55138

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Add a title to the installation guide #55138

merged 1 commit into from
Apr 11, 2019

Conversation

maxwell-k
Copy link
Contributor

SUMMARY

Add a title to the installation guide and also remove placeholder text that adds little.

Before this PR the title element in the HTML is <title>&lt;no title&gt; — Ansible Documentation</title>

See https://docs.ansible.com/ansible/devel/installation_guide/

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs

ADDITIONAL INFORMATION

Checked and built with:

cd docs/docsite
rstcheck rst/installation_guide/index.rst
make htmlsingle rst=installation_guide/index.rst

Then reviewed in a browser.

@maxwell-k
Add a title to the installation guide
99df9b4 
Also remove placeholder text.
@ansibot
Copy link
Contributor

ansibot commented Apr 11, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 11, 2019
gundalow
gundalow approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, thank you!

@gundalow gundalow merged commit be09f42 into ansible:devel Apr 11, 2019
@maxwell-k maxwell-k deleted the installation_guide_title branch April 11, 2019 11:45
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 15, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxwell-k @ansibot @gundalow @sivel