Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_domain - fix for checking for domain on new host #55195

Merged
merged 1 commit into from
Apr 12, 2019
Merged

win_domain - fix for checking for domain on new host #55195

merged 1 commit into from
Apr 12, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Also catch ActiveDirectoryOperationException which is raised from GetForest() if it cannot resolve the domain name. This issue was introduced with #53480.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_domain

@ansibot
Copy link
Contributor

ansibot commented Apr 12, 2019

cc @dagwieers @if-meaton @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Apr 12, 2019
@jborean93 jborean93 merged commit 6039ff9 into ansible:devel Apr 12, 2019
@jborean93 jborean93 deleted the win_domain-fix branch April 12, 2019 04:14
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 12, 2019
@jborean93
win_domain - fix for checking for domain on new host (ansible#55195)
5688522 
(cherry picked from commit 6039ff9)
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 12, 2019
@jborean93
win_domain - fix for checking for domain on new host (ansible#55195)
d4f2ba8 
(cherry picked from commit 6039ff9)
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 12, 2019
@jborean93
win_domain - fix for checking for domain on new host (ansible#55195)
d781eb3 
(cherry picked from commit 6039ff9)
This was referenced Apr 12, 2019
Merged
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.6 #55196
stable-2.7 #55197
stable-2.8 #55198

abadger pushed a commit that referenced this pull request Apr 12, 2019
@jborean93 @abadger
win_domain - fix for checking for domain on new host (#55195)
fb96c00 
(cherry picked from commit 6039ff9)
abadger pushed a commit that referenced this pull request Apr 12, 2019
@jborean93 @abadger
win_domain - fix for checking for domain on new host (#55195)
2fab4dd 
(cherry picked from commit 6039ff9)
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 15, 2019
abadger pushed a commit that referenced this pull request Apr 16, 2019
@jborean93 @abadger
win_domain - fix for checking for domain on new host (#55195)
455aa54 
(cherry picked from commit 6039ff9)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @sivel