Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue55222 #55223

Merged
merged 2 commits into from May 14, 2019
Merged

Issue55222 #55223

merged 2 commits into from May 14, 2019

Conversation

ajsiersema
Copy link
Contributor

SUMMARY

Python 3.7 compatibility for re.Pattern (Fixes #55222)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/network/common/config.py

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 12, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community needs_triage Needs a first human triage before being processed. networking Network category python3 support:network This issue/PR relates to code supported by the Ansible Network Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 12, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 12, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 12, 2019
Qalthos
Qalthos suggested changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes should solve the test issues. Please also remove the unrelated commits from this PR.

lib/ansible/module_utils/network/common/config.py Show resolved Hide resolved
lib/ansible/module_utils/network/common/config.py Show resolved Hide resolved
@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2019

@ajsiersema this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed ci_verified Changes made in this PR are causing tests to fail. labels Apr 18, 2019
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Apr 18, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 18, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 4, 2019
@NilashishC NilashishC merged commit 0ee673a into ansible:devel May 14, 2019
pabelanger pushed a commit to pabelanger/ansible that referenced this pull request Jun 12, 2019
@ajsiersema @pabelanger
Issue55222 (ansible#55223)
5119718 
* Python 3.7 compatibility for re.Pattern (Fixes ansible#55222)

* Python 3.7 compatibility for re.Pattern (Fixes ansible#55222)
pabelanger pushed a commit to pabelanger/ansible that referenced this pull request Jun 12, 2019
@ajsiersema @pabelanger
Issue55222 (ansible#55223)
693e1a0 
* Python 3.7 compatibility for re.Pattern (Fixes ansible#55222)

* Python 3.7 compatibility for re.Pattern (Fixes ansible#55222)
justjais pushed a commit to justjais/ansible that referenced this pull request Jun 13, 2019
@ajsiersema @justjais
Issue55222 (ansible#55223)
1568cef 
* Python 3.7 compatibility for re.Pattern (Fixes ansible#55222)

* Python 3.7 compatibility for re.Pattern (Fixes ansible#55222)

(cherry picked from commit 0ee673a)
@justjais justjais mentioned this pull request Jun 13, 2019
Closed
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@ajsiersema @ndclt
Issue55222 (ansible#55223)
509ba61 
* Python 3.7 compatibility for re.Pattern (Fixes ansible#55222)

* Python 3.7 compatibility for re.Pattern (Fixes ansible#55222)
abadger pushed a commit that referenced this pull request Jun 17, 2019
@ajsiersema @abadger
Issue55222 (#55223)
0a8d237 
* Python 3.7 compatibility for re.Pattern (Fixes #55222)

* Python 3.7 compatibility for re.Pattern (Fixes #55222)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community networking Network category python3 stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.7 compatibility re._pattern_type -> re.Pattern
5 participants
@ajsiersema @ansibot @Qalthos @mattclay @NilashishC