Meraki - Initial unit tests #55251

kbreit · 2019-04-13T22:49:56Z

SUMMARY

This PR adds a few unit tests for Meraki module utility. It is bare bones but will be used on current and future PRs.

ISSUE TYPE

Test Pull Request

COMPONENT NAME

lib/ansible/module_utils/network/meraki/meraki.py

ADDITIONAL INFORMATION

ansibot · 2019-05-22T16:17:35Z

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

test/units/module_utils/network/meraki/test_meraki.py:68:20: undefined-variable Undefined variable 'Mock'
test/units/module_utils/network/meraki/test_meraki.py:69:7: undefined-variable Undefined variable 'args'

click here for bot help

- Uses pytest's fixtures structure, not classes - Added a test file for importing

mattclay · 2019-08-06T01:04:13Z

test/units/module_utils/network/meraki/test_meraki.py

+
+
+def test_fetch_url_404(module, mocker):
+    mocker.patch('ansible.module_utils.urls.fetch_url')


The patch needs to be applied where name is used, not where it is defined:

Suggested change

mocker.patch('ansible.module_utils.urls.fetch_url')

mocker.patch('ansible.module_utils.network.meraki.meraki.fetch_url')

See https://docs.python.org/3/library/unittest.mock.html#where-to-patch for details.

To apply the side effect, use this:

Suggested change

mocker.patch('ansible.module_utils.urls.fetch_url')

mocker.patch('ansible.module_utils.network.meraki.meraki.fetch_url', side_effect=mocked_fetch_url)

You'll also need to update mocked_fetch_url to accept args, like:

def mocked_fetch_url(*args, **kwargs):

mattclay · 2019-08-06T01:12:09Z

test/units/module_utils/network/meraki/test_meraki.py

+
+
+def mocked_fetch_url():
+    response_mock = Mock()


Remove this since it doesn't do anything and Mock isn't defined.

mattclay · 2019-08-06T01:12:24Z

test/units/module_utils/network/meraki/test_meraki.py

+        info = {'status': 404,
+                'body': "404 - Page is missing",
+                }
+    return (None, info)


You'll need to define info for both code paths.

mattclay · 2019-08-06T01:13:37Z

test/units/module_utils/network/meraki/test_meraki.py

+
+def mocked_fetch_url():
+    response_mock = Mock()
+    if args[0] == 'https://api.meraki.com/404':


This doesn't match because your test uses http:// instead of https://.

Oh, and args[0] is the module, so you want to look at args[1] for the url.

Also, the url I'm seeing from the test is: https://api.meraki.com/api/v0/http://api.meraki.com/404

ansibot · 2019-08-06T03:00:44Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/units/module_utils/network/meraki/test_meraki.py:128:0: missing-final-newline Final newline missing

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

test/units/module_utils/network/meraki/test_meraki.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/units/module_utils/network/meraki/test_meraki.py:0:0: missing: __metaclass__ = type

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/module_utils/network/meraki/test_meraki.py:128:26: W292 no newline at end of file

click here for bot help

ansibot · 2019-08-06T03:08:15Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/units/module_utils/network/meraki/test_meraki.py:128:0: missing-final-newline Final newline missing

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

test/units/module_utils/network/meraki/test_meraki.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/units/module_utils/network/meraki/test_meraki.py:0:0: missing: __metaclass__ = type

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/module_utils/network/meraki/test_meraki.py:128:26: W292 no newline at end of file

click here for bot help

ansibot · 2019-08-07T03:11:13Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/units/module_utils/network/meraki/test_meraki.py:24:0: misplaced-future __future__ import is not the first non docstring statement

click here for bot help

ansibot · 2019-08-07T03:18:27Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/units/module_utils/network/meraki/test_meraki.py:24:0: misplaced-future __future__ import is not the first non docstring statement

click here for bot help

jillr removed the needs_triage Needs a first human triage before being processed. label Apr 18, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 26, 2019

kbreit mentioned this pull request May 16, 2019

Network Working Group Meeting Agenda 3 ansible/community#363

Closed

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label May 23, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 31, 2019

kbreit added 4 commits July 23, 2019 20:37

Initial commit for the most basic of unit tests

61a27f0

Rewrote unit test to actually work

e43d9d6

- Uses pytest's fixtures structure, not classes - Added a test file for importing

Whitespace fixes

7b762a7

Draft version of the mock unit test

36ce831

ansibot added the has_issue label Jul 26, 2019

mattclay reviewed Aug 6, 2019

View reviewed changes

Modify code to actually work!

39d95c5

kbreit force-pushed the meraki/initial_unit_tests branch from e037105 to 39d95c5 Compare August 6, 2019 02:40

ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 6, 2019

Add 429 testing

9fb9eb6

ansible-test fixes

34121f9

kbreit added 2 commits August 7, 2019 06:28

Resort lines

0a061bf

Fix import for 2.x compatibility

03e13d8

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 9, 2019

Qalthos added test This PR relates to tests. and removed feature This issue/PR relates to a feature request. labels Aug 14, 2019

Qalthos approved these changes Aug 14, 2019

View reviewed changes

Qalthos merged commit f52657f into ansible:devel Aug 14, 2019

kbreit deleted the meraki/initial_unit_tests branch August 16, 2019 17:35

ansible locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Meraki - Initial unit tests #55251

Meraki - Initial unit tests #55251

kbreit commented Apr 13, 2019 •

edited by Qalthos

ansibot commented May 22, 2019

mattclay Aug 6, 2019

mattclay Aug 6, 2019

mattclay Aug 6, 2019

mattclay Aug 6, 2019

mattclay Aug 6, 2019

mattclay Aug 6, 2019

mattclay Aug 6, 2019

ansibot commented Aug 6, 2019

ansibot commented Aug 6, 2019

ansibot commented Aug 7, 2019

ansibot commented Aug 7, 2019



		def test_fetch_url_404(module, mocker):
		mocker.patch('ansible.module_utils.urls.fetch_url')

	mocker.patch('ansible.module_utils.urls.fetch_url')
	mocker.patch('ansible.module_utils.network.meraki.meraki.fetch_url')

Meraki - Initial unit tests #55251

Meraki - Initial unit tests #55251

Conversation

kbreit commented Apr 13, 2019 • edited by Qalthos

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibot commented May 22, 2019

mattclay Aug 6, 2019

Choose a reason for hiding this comment

mattclay Aug 6, 2019

Choose a reason for hiding this comment

mattclay Aug 6, 2019

Choose a reason for hiding this comment

mattclay Aug 6, 2019

Choose a reason for hiding this comment

mattclay Aug 6, 2019

Choose a reason for hiding this comment

mattclay Aug 6, 2019

Choose a reason for hiding this comment

mattclay Aug 6, 2019

Choose a reason for hiding this comment

ansibot commented Aug 6, 2019

ansibot commented Aug 6, 2019

ansibot commented Aug 7, 2019

ansibot commented Aug 7, 2019

kbreit commented Apr 13, 2019 •

edited by Qalthos