Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving documentation of the aws_ec2 inventory plugin #55255

Merged
merged 1 commit into from Apr 15, 2019
Merged

Improving documentation of the aws_ec2 inventory plugin #55255

merged 1 commit into from Apr 15, 2019

Conversation

jtyr
Copy link
Contributor

@jtyr jtyr commented Apr 14, 2019

SUMMARY

This PR is improving documentation fo the aws_ec2 plugin.

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

aws_ec2

ADDITIONAL INFORMATION

N/A

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 14, 2019
@Akasurde Akasurde requested review from goneri and jillr April 14, 2019 16:13
@kbreit
Copy link
Contributor

kbreit commented Apr 14, 2019

lgtm

bcoca
bcoca previously requested changes Apr 15, 2019
View reviewed changes
lib/ansible/plugins/inventory/aws_ec2.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 15, 2019
@acozine acozine dismissed bcoca’s stale review April 15, 2019 20:07

Concerns addressed - thanks!

@acozine acozine merged commit 720f62b into ansible:devel Apr 15, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 16, 2019
acozine pushed a commit to acozine/ansible that referenced this pull request Apr 18, 2019
@jtyr @acozine
Improving documentation of the aws_ec2 inventory plugin (ansible#55255)
4f47278 
(cherry picked from commit 720f62b)
@acozine acozine mentioned this pull request Apr 19, 2019
Merged
acozine added a commit that referenced this pull request Apr 22, 2019
@acozine
Improving documentation of the aws_ec2 inventory plugin (#55255) (#55542
30906ff 
)

(cherry picked from commit 720f62b)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

@goneri goneri goneri approved these changes

@bcoca bcoca bcoca left review comments

@jillr jillr Awaiting requested review from jillr

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 docs This issue/PR relates to or includes documentation. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jtyr @kbreit @goneri @bcoca @acozine @sivel @ansibot