Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Check return of FindByInventoryPath #55282

Merged
merged 1 commit into from
Apr 18, 2019
Merged

VMware: Check return of FindByInventoryPath #55282

merged 1 commit into from
Apr 18, 2019

Conversation

Akasurde
Copy link
Member

SUMMARY

Check return value of FindByInventoryPath API which is used for
finding desired folder to deploy OVF.

Fixes: #54823

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/54823-vmware_deploy_ovf-folder.yml
lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py

@Akasurde
VMware: Check return of FindByInventoryPath
5c27676 
Check return value of FindByInventoryPath API which is used for
finding desired folder to deploy OVF.

Fixes: ansible#54823

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Apr 15, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Apr 15, 2019

cc @Tomorrow9 @ckotte @dav1x @lparkes @sivel @warthog9
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Apr 15, 2019
@Akasurde Akasurde requested review from goneri and jillr April 17, 2019 03:17
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Apr 17, 2019
@goneri
Copy link
Contributor

goneri commented Apr 17, 2019

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 17, 2019
@Akasurde Akasurde merged commit ffce456 into ansible:devel Apr 18, 2019
@Akasurde Akasurde deleted the i54823 branch April 18, 2019 03:56
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@Akasurde @ndclt
VMware: Check return of FindByInventoryPath (ansible#55282)
42dfdb9 
Check return value of FindByInventoryPath API which is used for
finding desired folder to deploy OVF.

Fixes: ansible#54823

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jillr jillr jillr approved these changes

@goneri goneri Awaiting requested review from goneri

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vmware_deploy_ovf.py not check variable “folder” is None or not
4 participants
@Akasurde @ansibot @goneri @jillr