Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_interface DI delay only when operation state check is requested #55355

Merged
merged 2 commits into from
Apr 16, 2019
Merged

nxos_interface DI delay only when operation state check is requested #55355

merged 2 commits into from
Apr 16, 2019

Conversation

trishnaguha
Copy link
Member

SUMMARY

cherry-pick 0fe6bf9

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_interface.py

chrisvanheuveln and others added 2 commits April 16, 2019 09:37
@chrisvanheuveln @trishnaguha
nxos_interface:DI: delay only when operation state check is requested (…
e19be08 
…ansible#54862)

* nxos_interface:DI: should only use delay when operation state check is requested

There is a 10 second delay that is added for every interface that is changed.
This delay should only occur when a task sets one of the `want` vars.

* /return/continue/

(cherry picked from commit 0fe6bf9)
@trishnaguha
changelog
a353fd6 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot
Copy link
Contributor

ansibot commented Apr 16, 2019

cc @chrisvanheuveln @jedelman8 @mikewiebe @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Apr 16, 2019
@abadger abadger merged commit ca49ae7 into ansible:stable-2.7 Apr 16, 2019
@abadger
Copy link
Contributor

abadger commented Apr 16, 2019

Merged for the 2.7.11 release.

@trishnaguha trishnaguha deleted the nxos_interface_27_fix branch April 17, 2019 05:34
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 23, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trishnaguha @ansibot @abadger @sivel @chrisvanheuveln