Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User - Do not add incompatible flags in local mode #55401

Merged
merged 1 commit into from Jun 27, 2019
Merged

User - Do not add incompatible flags in local mode #55401

merged 1 commit into from Jun 27, 2019

Conversation

samdoran
Copy link
Contributor

SUMMARY

Fixes #48722

Omit -G and -A flags when using luseradd since that command does not support those flags.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

/lib/ansible/modules/system/user.py

@samdoran samdoran force-pushed the issue/48722-user-local-group-option branch from 1f7299c to 4fdfdd8 Compare April 16, 2019 21:10
@samdoran samdoran mentioned this pull request Apr 16, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Apr 16, 2019

cc @sfromm
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category labels Apr 16, 2019
@jillr jillr removed the needs_triage Needs a first human triage before being processed. label Apr 18, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 26, 2019
@samdoran samdoran force-pushed the issue/48722-user-local-group-option branch from 4fdfdd8 to 39e7e77 Compare May 14, 2019 20:39
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 14, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 22, 2019
@samdoran
Copy link
Contributor Author

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 27, 2019
@ansibot ansibot merged commit 20ad120 into ansible:devel Jun 27, 2019
samdoran added a commit to samdoran/ansible that referenced this pull request Jun 27, 2019
@samdoran
[stable-2.8] Omit -A and -G options in local mode since luseradd does…
9f3a635 
… not support these (ansible#55401)

Add integration tests
(cherry picked from commit 20ad120)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@samdoran samdoran mentioned this pull request Jun 27, 2019
Merged
agowa pushed a commit to agowa/ansible-1 that referenced this pull request Jun 30, 2019
@samdoran @agowa
Omit -A and -G options in local mode since luseradd does not support …
cd25632 
…these (ansible#55401)

Add integration tests
abadger pushed a commit that referenced this pull request Jul 22, 2019
@samdoran @abadger
[stable-2.8] Omit -A and -G options in local mode since luseradd does…
e0dbe1b 
… not support these (#55401) (#58480)

* [stable-2.8] Omit -A and -G options in local mode since luseradd does not support these (#55401)

Add integration tests
(cherry picked from commit 20ad120)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* User - make groups and append mutually exclusive with local (#59309)

* Update intigration tests

(cherry picked from commit 8edad83)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bcoca bcoca

Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module user, luseradd: error parsing arguments
4 participants
@samdoran @ansibot @bcoca @jillr