Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wait of image disk after upload #55426

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Add wait of image disk after upload #55426

merged 1 commit into from
Apr 26, 2019

Conversation

machacekondra
Copy link
Contributor

SUMMARY

This PR add a proper wait for disk image after upload, previsouly we waited only for LUN disk, which is wrong, we should wait only in case of non-LUN disk.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_disk

ADDITIONAL INFORMATION

@machacekondra machacekondra mentioned this pull request Apr 17, 2019
Merged
@ansibot
Copy link
Contributor

ansibot commented Apr 17, 2019

cc @mnecas @mwperina
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Apr 17, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 25, 2019
mwperina
mwperina approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 26, 2019
@ansibot ansibot merged commit 213501a into ansible:devel Apr 26, 2019
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@machacekondra @ndclt
Add wait of image disk after upload (ansible#55426)
e5746b2
@ansible ansible locked and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@machacekondra @ansibot @mwperina