Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update openssl_privatekey.py #55438

Merged
merged 3 commits into from May 3, 2019
Merged

Update openssl_privatekey.py #55438

merged 3 commits into from May 3, 2019

Conversation

snagoor
Copy link
Contributor

@snagoor snagoor commented Apr 17, 2019

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@snagoor
Update openssl_privatekey.py
da87372 
<!--- Your description here -->

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Apr 17, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @felixfontein @puiterwijk @resmo
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Apr 17, 2019
felixfontein
felixfontein approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for spotting and fixing this!

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 17, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 23, 2019
@felixfontein @snagoor
Update lib/ansible/modules/crypto/openssl_privatekey.py
96d64b6 
Co-Authored-By: snagoor <nagoor.s@gmail.com>
felixfontein
felixfontein reviewed Apr 25, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akasurde is the new formulation OK for you?

@felixfontein @snagoor
Update lib/ansible/modules/crypto/openssl_privatekey.py
241a1aa 
Co-Authored-By: snagoor <nagoor.s@gmail.com>
felixfontein
felixfontein approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 3, 2019
@gundalow gundalow merged commit 2925f69 into ansible:devel May 3, 2019
@felixfontein
Copy link
Contributor

@snagoor thanks for fixing this!
@Akasurde thanks for checking this!
@gundalow thanks for merging this!

I'll create backports so this will eventually show up in the docs.

felixfontein pushed a commit to felixfontein/ansible that referenced this pull request May 3, 2019
@snagoor @felixfontein
Update openssl_privatekey.py (ansible#55438)
0381a33 
* Update openssl_privatekey.py

<!--- Your description here -->

+label: docsite_pr

* Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>

* Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>
(cherry picked from commit 2925f69)
felixfontein pushed a commit to felixfontein/ansible that referenced this pull request May 3, 2019
@snagoor @felixfontein
Update openssl_privatekey.py (ansible#55438)
e3062ea 
* Update openssl_privatekey.py

<!--- Your description here -->

+label: docsite_pr

* Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>

* Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>
(cherry picked from commit 2925f69)
This was referenced May 3, 2019
Merged
Merged
acozine pushed a commit that referenced this pull request May 6, 2019
@felixfontein @acozine
Update openssl_privatekey.py (#55438) (#56067)
f084305 
Docs: Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>
(cherry picked from commit 2925f69)
acozine pushed a commit that referenced this pull request May 6, 2019
@felixfontein @acozine
Update openssl_privatekey.py (#55438) (#56066)
7705c90 
Docs: Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>
(cherry picked from commit 2925f69)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde left review comments

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. crypto Crypto community (ACME, openssl, letsencrypt) docsite_pr This PR is created from documentation using the "Edit on GitHub" link. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@snagoor @ansibot @felixfontein @Akasurde @dagwieers @gundalow