Ovirt add job #55440
Merged
Ovirt add job #55440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
mattclay
added
the
ci_verified
ansibot
removed
the
needs_triage
| ) | ||
|
|
||
|
|
||
| def build_job(module): |
There was a problem hiding this comment.
pass here just description, as it's the only parameter you need.
| ) | ||
|
|
||
|
|
||
| def attach_steps(module, entity_id, jobs_service): |
There was a problem hiding this comment.
here you need just a 'steps' not whole module as well.
| ) | ||
|
|
||
|
|
||
| def attach_steps(module, entity_id, jobs_service): |
There was a problem hiding this comment.
also please rename entity_id to job_id, no need to have it too generic here
| ret = { | ||
| 'changed': changed, | ||
| 'id': getattr(job, 'id', None), | ||
| type(job).__name__.lower(): get_dict_of_struct( |
There was a problem hiding this comment.
change 'type(job).name.lower()' to just 'job' no need to do it generic here
| type(job).__name__.lower(): get_dict_of_struct( | ||
| struct=job, | ||
| connection=connection, | ||
| fetch_nested=module.params.get('fetch_nested'), |
There was a problem hiding this comment.
I would add here fetch_nested=True, because we always want to return steps.
| required: true | ||
| state: | ||
| description: | ||
| - "Should the setp be present/absent/failed." |
| state: | ||
| description: | ||
| - "Should the job be present/absent/failed." | ||
| - "Present have alias started and absent have alias finished, you can use both." |
There was a problem hiding this comment.
please use C() around possible values of the state
| state: | ||
| description: | ||
| - "Should the job be present/absent/failed." | ||
| - "Present have alias started and absent have alias finished, you can use both." |
There was a problem hiding this comment.
I would write: C(started) is alias for C(present). C(finished) is alias for C(absent). Same in the steps.
ansibot
removed
the
ci_verified
|
@KKoukiou @derez @machacekondra @mwperina @nasx As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add |
ansibot
added
community_review
|
shipit |
ansibot
added
shipit
ansibot
added
community_review
ansibot
added
the
stale_ci
|
shipit |
ansibot
added
shipit
resmo
approved these changes
Jun 10, 2019
agowa
pushed a commit
to agowa/ansible-1
that referenced
this pull request
Jun 30, 2019
* init ovirt_job module * ovirt job add state finished * redone logic in ovirt job * ovirt jobs add docs * ovirt job update docs * update failed status * ovirt job update return docs * ovirt job update docs * check if job and step has finished * remove job status end
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Ovirt add job module
ISSUE TYPE
COMPONENT NAME
Ovirt
ADDITIONAL INFORMATION