modules/notification/irc: Fix channel joining for some IRC servers. #55444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2019 10:09
Some IRC servers may return the channel in a different case than requested. For instance, you might request "foo" but the server returns "FOO". The regular expression matching must be case-insensitive for the join response in order to handle this.
ansibot
added
affects_2.9
|
shipit |
ansibot
removed
the
needs_triage
ndclt
pushed a commit
to ndclt/ansible
that referenced
this pull request
Jun 13, 2019
…nsible#55444) * Fix channel joining for some IRC servers. Some IRC servers may return the channel in a different case than requested. For instance, you might request "foo" but the server returns "FOO". The regular expression matching must be case-insensitive for the join response in order to handle this. * ansible style guidelines want spaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix channel joining for some IRC servers.
Some IRC servers may return the channel in a different case than
requested. For instance, you might request "foo" but the server
returns "FOO". The regular expression matching must be case-insensitive
for the join response in order to handle this.
ISSUE TYPE
COMPONENT NAME
modules/notification/irc
ADDITIONAL INFORMATION
Prior ticket here that was never resolved: ansible/ansible-modules-extras#429