Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes misleading padding from highlighted results of a search query #55464

Merged

Conversation

shaikhfaisal
Copy link
Contributor

SUMMARY

Removes misleading padding from highlighted results of a search query on the documentation site.

Fixes #54374

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Documentation

@shaikhfaisal shaikhfaisal marked this pull request as ready for review April 17, 2019 17:11
@ansibot
Copy link
Contributor

ansibot commented Apr 17, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 17, 2019
@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Apr 17, 2019
@acozine
Copy link
Contributor

acozine commented Apr 18, 2019

Thanks @shaikhfaisal for fixing this!

With this PR, here's how highlighting looks:

Screen Shot 2019-04-18 at 11 25 06 AM

@acozine acozine merged commit 0330ea6 into ansible:devel Apr 18, 2019
acozine pushed a commit to acozine/ansible that referenced this pull request Apr 18, 2019
@shaikhfaisal
Copy link
Contributor Author

Glad I could help @acozine !

acozine added a commit that referenced this pull request Apr 22, 2019
acozine pushed a commit to acozine/ansible that referenced this pull request May 20, 2019
acozine pushed a commit to acozine/ansible that referenced this pull request May 20, 2019
acozine added a commit that referenced this pull request May 21, 2019
acozine added a commit that referenced this pull request May 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The search highlight seems to add padding in code blocks
3 participants