Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_region - fix format issues when using psrp #55487

Merged
merged 1 commit into from
Apr 18, 2019
Merged

win_region - fix format issues when using psrp #55487

merged 1 commit into from
Apr 18, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Using win_region with psrp fails to detect and set the user format value. This is because the runspace that hosts the PSRP service has an explicit culture of en-US set when the runspace is created. This code change uses the Win32 API to get the culture value and uses the legacy way of changing the values in all cases.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

psrp

@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2019

cc @dagwieers @if-meaton @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Apr 18, 2019
@jborean93 jborean93 merged commit f247c21 into ansible:devel Apr 18, 2019
@jborean93 jborean93 deleted the win_region-psrp branch April 18, 2019 03:42
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 18, 2019
@jborean93
win_region - fix format issues when using psrp (ansible#55487)
a6a99b2 
(cherry picked from commit f247c21)
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 18, 2019
@jborean93
win_region - fix format issues when using psrp (ansible#55487)
45c8ee2 
(cherry picked from commit f247c21)
This was referenced Apr 18, 2019
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.6 #55492
stable-2.7 #55493

@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Apr 18, 2019
abadger pushed a commit that referenced this pull request Apr 23, 2019
@jborean93 @abadger
Merge pull request #55493 from jborean93/win_region-psrp-2.8
d83e722 
win_region - fix format issues when using psrp (#55487) - 2.8
abadger pushed a commit that referenced this pull request Apr 24, 2019
@jborean93 @abadger
win_region - fix format issues when using psrp (#55487)
e51edbf 
(cherry picked from commit f247c21)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @bcoca