Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Support For EVPN in BGP Module #55503

Merged
merged 5 commits into from
May 11, 2019
Merged

Adding Support For EVPN in BGP Module #55503

merged 5 commits into from
May 11, 2019

Conversation

anasbadaha
Copy link
Contributor

Signed-off-by: Anas Badaha anasb@mellanox.com

SUMMARY

Adding Support for EVPN in onyx_bgp for onyx switches

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/network/onyx/onyx_bgp.py
test/units/modules/network/onyx/fixtures/onyx_bgp_show.cfg
test/units/modules/network/onyx/test_onyx_bgp.py

ADDITIONAL INFORMATION
ansible 2.9.0.dev0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /.autodirect/mtrswgwork/anasb/ansible_dev8/lib/ansible
  executable location = /.autodirect/mtrswgwork/anasb/ansible_dev8/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

@anasbadaha
Adding Support For EVPN in BGP Module
5acf57c 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @samerd @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 18, 2019
@anasbadaha
Fix Pep8 Failures in onyx_bgp.py
98567c2 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@anasbadaha
Fix Pep8 Failures in onyx_bgp.py Phase 2
5a9b8e1 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 18, 2019
samerd
samerd suggested changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@samerd samerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anasbadaha
looks great.
However, I have two small comments:
1- All regular expressions started with: ^\s.router
should be changed to: ^\srouter

2- in function _generate_bgp_cmds
when checking: if curr_as_num != as_number:
you should also check if the vrf has been changed, then you have to remove the bgp and create a new one.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Apr 18, 2019
@anasbadaha
Fix Samer's Comments
3f0f298 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
@anasbadaha
Copy link
Contributor Author

Hi @samerd ,

I have fixed your comments related to function _generate_bgp_cmds and added a unit test for it as well.
Regarding Regex comment I saw it is working perfect and this will be more strong to Put .* after space in order to avoid changes in cli response.
Please approve it if it is Ok for you now.
Thanks

@anasbadaha
Remove file Variable
8c0de04 
Signed-off-by: Anas Badaha <anasb@mellanox.com>
samerd
samerd approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@samerd samerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent Job @anasbadaha
Thanks

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 22, 2019
@samerd samerd mentioned this pull request Apr 22, 2019
Closed
@anasbadaha
Copy link
Contributor Author

Hi @justjais,

Can you please merge this PR if it is OK for you?

Thanks

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 1, 2019
ganeshrn
ganeshrn approved these changes May 11, 2019
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ganeshrn
Copy link
Member

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 11, 2019
@ansibot ansibot merged commit 0f852f0 into ansible:devel May 11, 2019
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@anasbadaha @ndclt
Adding Support For EVPN in BGP Module (ansible#55503)
86400f7 
* Adding Support For EVPN in BGP Module

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_bgp.py

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_bgp.py Phase 2

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Samer's Comments

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Remove file Variable

Signed-off-by: Anas Badaha <anasb@mellanox.com>
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@samerd samerd samerd approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 module This issue/PR relates to a module. networking Network category new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anasbadaha @ansibot @ganeshrn @samerd