Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update win_domain_group_membership.py #55594

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Update win_domain_group_membership.py #55594

merged 3 commits into from
Apr 24, 2019

Conversation

thefaftek
Copy link
Contributor

SUMMARY

Adding notes regarding a computer object and fixing a typo!

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY

Adding notes regarding a computer object and fixing a typo!

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

win_domain_group_membership

ADDITIONAL INFORMATION

No change in output

@thefaftek
Update win_domain_group_membership.py
204cc77 
##### SUMMARY
Adding notes regarding a computer object and fixing a typo!


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Apr 22, 2019

cc @dagwieers @if-meaton @jborean93 @jhawkesworth @jiuka @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Apr 22, 2019
@thefaftek
Copy link
Contributor Author

I noticed this got flagged for affects_2.9. Any chance this can get pulled into 2.8 since it's just a doc fix for clarification?

@acozine
Copy link
Contributor

acozine commented Apr 23, 2019

@thefaftek thank you for contributing to the Ansible docs!

Our bot is marking all PRs affects_2.9 because the current devel branch is 2.9 - we are currently backporting docs changes to stable-2.8 after merging as well.

I don't entirely understand the line you added here. Should I add the $ to the beginning or the end of the computer object, and what does the format look like? server01.mydomain.com$? An example might help me suggest refinements to that line.

@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Apr 23, 2019
@jborean93
Copy link
Contributor

@acozine the $ is a suffix and already as an example at https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_domain_group_membership.py#L85-L90. Just need the clarification that it should do onto the end. The value is the sAMAccountName attribute for the AD object of the member.

@thefaftek
Copy link
Contributor Author

@acozine My apologies for the lack of an example. I've added a second commit with an example attached and clarifying that this needs to be as a suffix. Thanks for getting back so fast on this one!

@acozine acozine requested a review from jborean93 April 24, 2019 13:53
@acozine
Copy link
Contributor

acozine commented Apr 24, 2019

Thanks @thefaftek and @jborean93!

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 24, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed small_patch needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 24, 2019
@acozine acozine merged commit 3f0900f into ansible:devel Apr 24, 2019
acozine pushed a commit to acozine/ansible that referenced this pull request May 10, 2019
@thefaftek @acozine
Update win_domain_group_membership.py (ansible#55594)
453d43e 
* Update win_domain_group_membership.py by adding notes regarding a computer object and fixing a typo

(cherry picked from commit 3f0900f)
@acozine acozine mentioned this pull request May 10, 2019
Merged
acozine added a commit that referenced this pull request May 13, 2019
@acozine
Backport/2.8/docs modules omnibus (#56316)
9b867fb 
* Update gcp_container_cluster_facts.py (#55475) : 'state' is not a supported parameter in this module

(cherry picked from commit 8c7e38a)

* Update win_dns_record.py (#55378): Update examples to show values are strings.

(cherry picked from commit 3fd27f0)

* sensu_subscription very minor docstring typo (#55675)

(cherry picked from commit 2cfaf6e)

* Update win_domain_group_membership.py (#55594): add notes regarding a computer object and fixing a typo

(cherry picked from commit 3f0900f)

* hcloud_server: clarify further for usage of `ssh_keys` (#55713)

(cherry picked from commit 6e9379f)

* Fix template lookup description (#55557): describe that it returns template content with substituted variables.

(cherry picked from commit 9c038b2)

* Update ec2_eip_facts.py (#53040): Add several additional examples showing how to filter on tag, how to filter on the EIP allocation id, and how to set a fact using the output.

(cherry picked from commit 1e2cbef)

* Update ali_instance_facts examples in documentation (#55760) (#55803)

(cherry picked from commit 357daff)

* Update setup.py (#55871): adds a note on privileges needed on BSD systems to use dmidecode

(cherry picked from commit c181e56)

* Remove illegal basic provisioning example (#55892): The bare minimum example in the docs (i.e. only supplying name, state, and cluster) results in the error `state is present but all of the following are missing: task_definition, desired_count`.

(cherry picked from commit c195645)

* clarify docs for rel src state hard (#55972)

(cherry picked from commit 0b00220)

* correct method docs (#55961)

(cherry picked from commit ea57377)

* Update sample (#55654): Correct logConfiguration example on the ecs_taskdefinition module.

(cherry picked from commit 23ddc77)

* add missing exported state do doc string (#56109)

(cherry picked from commit ba9f0d5)

* package_facts: Trivial docs cleanup (#56015): use
the current YAML style and remove unnecessary quotes around `auto`.

Signed-off-by: Major Hayden <major@redhat.com>
(cherry picked from commit 93d24ef)

* Update include_role description (#56001) to discuss tasks: use

(cherry picked from commit 8cb7640)

* Sync required flags from argument_spec to docs (#56121): arguments for certificate, private_key and password were marked as required in the ArgumentSpec, but not in the documentation. 

(cherry picked from commit 6b474a1)

* updated ec2.py to describe required parameters (#56197): for each option for `state`

(cherry picked from commit 5346a5c)

* Update os_image documentation (#49705) to show auth details

(cherry picked from commit f5326aa)
amuraleedhar pushed a commit to amuraleedhar/ansible that referenced this pull request May 21, 2019
@acozine
Backport/2.8/docs modules omnibus (ansible#56316)
a2eee49 
* Update gcp_container_cluster_facts.py (ansible#55475) : 'state' is not a supported parameter in this module

(cherry picked from commit 8c7e38a)

* Update win_dns_record.py (ansible#55378): Update examples to show values are strings.

(cherry picked from commit 3fd27f0)

* sensu_subscription very minor docstring typo (ansible#55675)

(cherry picked from commit 2cfaf6e)

* Update win_domain_group_membership.py (ansible#55594): add notes regarding a computer object and fixing a typo

(cherry picked from commit 3f0900f)

* hcloud_server: clarify further for usage of `ssh_keys` (ansible#55713)

(cherry picked from commit 6e9379f)

* Fix template lookup description (ansible#55557): describe that it returns template content with substituted variables.

(cherry picked from commit 9c038b2)

* Update ec2_eip_facts.py (ansible#53040): Add several additional examples showing how to filter on tag, how to filter on the EIP allocation id, and how to set a fact using the output.

(cherry picked from commit 1e2cbef)

* Update ali_instance_facts examples in documentation (ansible#55760) (ansible#55803)

(cherry picked from commit 357daff)

* Update setup.py (ansible#55871): adds a note on privileges needed on BSD systems to use dmidecode

(cherry picked from commit c181e56)

* Remove illegal basic provisioning example (ansible#55892): The bare minimum example in the docs (i.e. only supplying name, state, and cluster) results in the error `state is present but all of the following are missing: task_definition, desired_count`.

(cherry picked from commit c195645)

* clarify docs for rel src state hard (ansible#55972)

(cherry picked from commit 0b00220)

* correct method docs (ansible#55961)

(cherry picked from commit ea57377)

* Update sample (ansible#55654): Correct logConfiguration example on the ecs_taskdefinition module.

(cherry picked from commit 23ddc77)

* add missing exported state do doc string (ansible#56109)

(cherry picked from commit ba9f0d5)

* package_facts: Trivial docs cleanup (ansible#56015): use
the current YAML style and remove unnecessary quotes around `auto`.

Signed-off-by: Major Hayden <major@redhat.com>
(cherry picked from commit 93d24ef)

* Update include_role description (ansible#56001) to discuss tasks: use

(cherry picked from commit 8cb7640)

* Sync required flags from argument_spec to docs (ansible#56121): arguments for certificate, private_key and password were marked as required in the ArgumentSpec, but not in the documentation. 

(cherry picked from commit 6b474a1)

* updated ec2.py to describe required parameters (ansible#56197): for each option for `state`

(cherry picked from commit 5346a5c)

* Update os_image documentation (ansible#49705) to show auth details

(cherry picked from commit f5326aa)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 Awaiting requested review from jborean93

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thefaftek @ansibot @acozine @jborean93 @dagwieers