Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated get_md5 from stat #55659

Merged
merged 7 commits into from
May 8, 2019
Merged

remove deprecated get_md5 from stat #55659

merged 7 commits into from
May 8, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 23, 2019

fixes #55309

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

stat

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 23, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 25, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 26, 2019

cc @ptux
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 26, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 4, 2019
agaffney
agaffney reviewed May 6, 2019
View reviewed changes
changelogs/fragments/stat_no_md5.yml Outdated Show resolved Hide resolved
lib/ansible/modules/files/stat.py Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 6, 2019
@ansibot
Copy link
Contributor

ansibot commented May 7, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added test This PR relates to tests. core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 7, 2019
felixfontein
felixfontein approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 8, 2019
@bcoca bcoca merged commit deae5b1 into ansible:devel May 8, 2019
@bcoca bcoca deleted the stat_remove_dep branch May 8, 2019 14:45
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@bcoca @ndclt
remove deprecated get_md5 from stat (ansible#55659)
c10be41 
* remove deprecated get_md5 from stat

  fixes ansible#55309

* removed get_md5 from tests involving stat

* keep get_md5 but hide it

* rst it

* ammended comment

* ws

* added ignore for hidden md5
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agaffney agaffney agaffney left review comments

@jamescassell jamescassell jamescassell approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. files Files category module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stat contains deprecated call to be removed in 2.9
5 participants
@bcoca @ansibot @agaffney @jamescassell @felixfontein